723545 - Robocop - Adding a new test is error prone

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Makefile fixes

When adding new tests, I consistently make two mistakes.

One is to name my java file .java instead of .java.in, which only gets detected after I finish building and try to run the test. This can be fixed by include *.java along with *.java.in into the build, so that the #filter lines will break the build (or if it's a valid .java file, pulls it into the build as expected).

The other is to add new .html files and forget to add it to the Makefile. This can be fixed by include *.html instead of having to enumerate them individually. This also makes it consistent with the *.java glob.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 593856 [details] [diff] [review]
Makefile fixes

Review of attachment 593856 [details] [diff] [review]:
-----------------------------------------------------------------

I like the *.html, I don't like the *.java.

::: build/mobile/robocop/Makefile.in
@@ +63,5 @@
>    $(NULL)
>  
> +_JAVA_TESTS = $(patsubst $(TESTPATH)/%.in,%,$(wildcard $(TESTPATH)/*.java.in)) \
> +              $(wildcard $(TESTPATH)/*.java) \
> +              $(NULL)

I don't like the *.java.  We need the filtering because the package name is different between users and nightly/release.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Makefile fixes (v2)

Ok, taking out the *.java stuff, leaving in the *.html.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/096b65714f60

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/096b65714f60