Robocop - Adding a new test is error prone

RESOLVED FIXED in mozilla13

Status

Testing
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

Trunk
mozilla13
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 593856 [details] [diff] [review]
Makefile fixes

When adding new tests, I consistently make two mistakes.

One is to name my java file .java instead of .java.in, which only gets detected after I finish building and try to run the test. This can be fixed by include *.java along with *.java.in into the build, so that the #filter lines will break the build (or if it's a valid .java file, pulls it into the build as expected).

The other is to add new .html files and forget to add it to the Makefile. This can be fixed by include *.html instead of having to enumerate them individually. This also makes it consistent with the *.java glob.
Attachment #593856 - Flags: review?(jmaher)
Comment on attachment 593856 [details] [diff] [review]
Makefile fixes

Review of attachment 593856 [details] [diff] [review]:
-----------------------------------------------------------------

I like the *.html, I don't like the *.java.

::: build/mobile/robocop/Makefile.in
@@ +63,5 @@
>    $(NULL)
>  
> +_JAVA_TESTS = $(patsubst $(TESTPATH)/%.in,%,$(wildcard $(TESTPATH)/*.java.in)) \
> +              $(wildcard $(TESTPATH)/*.java) \
> +              $(NULL)

I don't like the *.java.  We need the filtering because the package name is different between users and nightly/release.
Attachment #593856 - Flags: review?(jmaher) → review-
Created attachment 593908 [details] [diff] [review]
Makefile fixes (v2)

Ok, taking out the *.java stuff, leaving in the *.html.
Attachment #593856 - Attachment is obsolete: true
Attachment #593908 - Flags: review?(jmaher)
Attachment #593908 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/096b65714f60
https://hg.mozilla.org/mozilla-central/rev/096b65714f60
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.