358 bytes, text/html
355 bytes, text/html
Assignee: nobody → rFobic
Priority: -- → P2
Created attachment 593866 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/335# Pointer to Github pull-request
Attachment #593866 - Flags: review?(poirot.alex)
I'd really like to see our team embrace Firefox team, Firefox codebase and all projects that are working *into* Firefox, like Devtools and Perf team. These teams managed to use the same Promise API. Devtools team has implemented its own Promise implementation, then Perf team has decided to use this existing implementation instead of crafting its own new wheel: http://mxr.mozilla.org/mozilla-central/source/browser/devtools/shared/Promise.jsm You may be interested by the upcoming module from Perf team called schedule.jsm: https://bug692420.bugzilla.mozilla.org/attachment.cgi?id=594212 I think it would be a valuable action, that would help us bootstraping projects in the upcoming Firefox workweek. What's your thought about this?
This implementaition has several issues that makes it poor feet For us. only creator of promise should have capabilities to resolve and not An every consumer that may not be trusted. I have talked about this several times with folks from dev tools on commonjs mailing list, bespin Mailing list and in person, so I don't think it make sense to start over again. Also since they don't face untrusted code it's not an issue for them. I don't think attempt to unify promise api across diff teams will be productive for anyone. We can attemp that later once we're happy with what we have.
Also it looks like `chainPromise` acts as `then` is supposed to. I wish they implemented http://wiki.commonjs.org/wiki/Promises/A spec, that way our promises could have been at least consumed by each other.
Created attachment 599898 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/350 Pointer to Github pull-request
Attachment #599898 - Flags: review?(poirot.alex)
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/ee0cbdec87c7daac69202df642ce051ef2e6414b Merge pull request #350 from Gozala/bug/micro-promise@723555 fix Bug 723555 - Implementation of promise abstraction r=@ochameau
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/f56aed287a981617fbdedb745e39d0a1465af5c4 Merge pull request #392 from Gozala/hotfix/promise Bug 723555 - Add files to the license test blacklist to fix oranges. a=@gozala
Comment on attachment 599898 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/350 Already r+ and landed in pull request.
Attachment #599898 - Flags: review?(poirot.alex) → review+
Comment on attachment 593866 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/335# Already r+ and landed on github.
Attachment #593866 - Flags: review?(poirot.alex) → review+
You need to log in before you can comment on or make changes to this bug.