Closed
Bug 72359
Opened 23 years ago
Closed 21 years ago
Anonymous table cells get extra margins?
Categories
(Core :: Layout: Tables, defect)
Core
Layout: Tables
Tracking
()
RESOLVED
FIXED
mozilla1.0.1
People
(Reporter: ian, Assigned: ian)
References
()
Details
(Keywords: css2, testcase, Whiteboard: [Hixie-P4] [have fix])
Attachments
(1 file)
414 bytes,
patch
|
bernd_mozilla
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
It appears that the anonymous cell marked in the fragment below with "***" is getting an extra margin. <float xmlns="http://www.example.org/"> <!--table--> <!--row--> <cell>THERE</cell> <!--/row--> <row> <!--cell--> <!-- *** --> <table> <!--row--> <cell>SHOULD B</cell> <cell>E N</cell> <cell>O RED</cell> <!--/row--> </table> <!--/cell--> </row> <cell>ANYWHERE</cell> <!--/table--> </float> See http://www.hixie.ch/tests/adhoc/css/box/table/001.xml for a test case. Note that until bug 72358 is fixed it will be hard to see this bug.
Assignee | ||
Comment 3•23 years ago
|
||
Hyatt has a fix for this on his branch.
Assignee: karnaze → hyatt
Status: ASSIGNED → NEW
Assignee | ||
Updated•23 years ago
|
Whiteboard: [Hixie-P4]
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: mozilla1.0 → mozilla0.9.2
Assignee | ||
Comment 5•23 years ago
|
||
Incidentally, the fix is simply to remove the padding on :table-cell and move it to the <td> rule. We just need the table folk to agree to it. Karnaze?
Whiteboard: [Hixie-P4] → [Hixie-P4] [have fix]
Updated•23 years ago
|
Target Milestone: mozilla1.0 → mozilla1.0.1
Comment 9•23 years ago
|
||
ian, if you make this change, then you need to run the block and table regression tests.
Assignee | ||
Comment 10•23 years ago
|
||
you bet
Comment 11•22 years ago
|
||
Reconfirmed using FizzillaCFM/2002071208. Setting All/All.
OS: Windows 2000 → All
Hardware: PC → All
Comment 12•21 years ago
|
||
we can safely remove this from ua.css as it is duplicated at html.css http://lxr.mozilla.org/seamonkey/source/layout/html/document/src/html.css#231 and http://lxr.mozilla.org/seamonkey/source/layout/html/document/src/html.css#238 I runned the regression tests: the tests that failed are: http://lxr.mozilla.org/seamonkey/source/layout/html/tests/table/bugs/bug2479-1.html and the 2479-2 ... http://lxr.mozilla.org/seamonkey/source/layout/html/tests/table/bugs/bug30985.html the tests 2479-xx are made by hixie , so the probability that one will ever see them in normal life is zero.
Attachment #124334 -
Flags: superreview?(dbaron)
Attachment #124334 -
Flags: review+
Attachment #124334 -
Flags: superreview?(dbaron) → superreview+
Comment 13•21 years ago
|
||
fix + testcase checked in
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•