Anonymous table cells get extra margins?

RESOLVED FIXED in mozilla1.0.1

Status

()

Core
Layout: Tables
--
minor
RESOLVED FIXED
16 years ago
3 years ago

People

(Reporter: Hixie (not reading bugmail), Assigned: Hixie (not reading bugmail))

Tracking

({css2, testcase})

Trunk
mozilla1.0.1
css2, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Hixie-P4] [have fix], URL)

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
It appears that the anonymous cell marked in the fragment below with "***" is
getting an extra margin.

  <float xmlns="http://www.example.org/">
   <!--table-->
    <!--row-->
     <cell>THERE</cell>
    <!--/row-->
    <row>
     <!--cell-->   <!-- *** -->
      <table>
       <!--row-->
        <cell>SHOULD B</cell>
        <cell>E N</cell>
        <cell>O RED</cell>
       <!--/row-->
      </table>
     <!--/cell-->
    </row>
    <cell>ANYWHERE</cell>
   <!--/table-->
  </float>

See http://www.hixie.ch/tests/adhoc/css/box/table/001.xml for a test case.
Note that until bug 72358 is fixed it will be hard to see this bug.
(Assignee)

Updated

16 years ago
Depends on: 72358
Keywords: css2, mozilla1.0, testcase

Comment 1

16 years ago
Moving to m1.0
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0

Comment 2

16 years ago
QA contact update
QA Contact: chrisd → amar
(Assignee)

Updated

16 years ago
Depends on: 78695
(Assignee)

Comment 3

16 years ago
Hyatt has a fix for this on his branch.
Assignee: karnaze → hyatt
Status: ASSIGNED → NEW
(Assignee)

Updated

16 years ago
Whiteboard: [Hixie-P4]

Updated

16 years ago
Status: NEW → ASSIGNED
Target Milestone: mozilla1.0 → mozilla0.9.2

Comment 4

16 years ago
not fixed on branch, ->1.0
Target Milestone: mozilla0.9.2 → mozilla1.0
(Assignee)

Comment 5

16 years ago
Incidentally, the fix is simply to remove the padding on :table-cell and move it
to the <td> rule. We just need the table folk to agree to it. Karnaze?
Whiteboard: [Hixie-P4] → [Hixie-P4] [have fix]

Comment 6

16 years ago
what's the status on this?

Updated

16 years ago
Target Milestone: mozilla1.0 → mozilla1.0.1

Comment 7

16 years ago
status?
(Assignee)

Comment 8

16 years ago
Taking bug
Assignee: hyatt → ian
Status: ASSIGNED → NEW

Comment 9

16 years ago
ian, if you make this change, then you need to run the block and table 
regression tests.
(Assignee)

Comment 10

16 years ago
you bet

Comment 11

15 years ago
Reconfirmed using FizzillaCFM/2002071208. Setting All/All.
OS: Windows 2000 → All
Hardware: PC → All

Comment 12

14 years ago
Created attachment 124334 [details] [diff] [review]
patch

we can safely remove this from ua.css as it is duplicated at html.css
http://lxr.mozilla.org/seamonkey/source/layout/html/document/src/html.css#231
and
http://lxr.mozilla.org/seamonkey/source/layout/html/document/src/html.css#238

I runned the regression tests:
the tests that failed are: 
http://lxr.mozilla.org/seamonkey/source/layout/html/tests/table/bugs/bug2479-1.html

 and the 2479-2 ...

http://lxr.mozilla.org/seamonkey/source/layout/html/tests/table/bugs/bug30985.html


the tests 2479-xx are made by hixie , so the probability that one will ever see
them in normal life is zero.

Updated

14 years ago
Attachment #124334 - Flags: superreview?(dbaron)
Attachment #124334 - Flags: review+
Attachment #124334 - Flags: superreview?(dbaron) → superreview+

Comment 13

14 years ago
fix + testcase checked in
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.