Closed Bug 723619 Opened 10 years ago Closed 10 years ago

Robocop - need a way to get the painted surface after animations

Categories

(Testing :: General, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla13

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(2 files)

I was trying to write a test and was running into problems where getting the painted surface after doing a double-tap would get one of the intermediate animation frames instead of waiting to the end. I realized I needed to wait until all the paints were done and then grab the screen.

Also this allows fixing a potential race condition in testLoad where the entire screen gets painted after calling loadUrl but before creating the paint expecter.
Attachment #593902 - Flags: review?(jmaher)
Attachment #593902 - Attachment is patch: true
Comment on attachment 593902 [details] [diff] [review]
Add a blockUntilClear function

Review of attachment 593902 [details] [diff] [review]:
-----------------------------------------------------------------

took me a minute and an IRC chat to figure out what we were doing here.  The comments make sense once I understood that we were waiting for a series of events to transpire.
Attachment #593902 - Flags: review?(jmaher) → review+
Comment on attachment 593903 [details] [diff] [review]
Fix race condition in testLoad

Review of attachment 593903 [details] [diff] [review]:
-----------------------------------------------------------------

very cool!
Attachment #593903 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/mozilla-central/rev/10aabf337120
https://hg.mozilla.org/mozilla-central/rev/6b21642cc621
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.