723619 - Robocop - need a way to get the painted surface after animations

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Add a blockUntilClear function

I was trying to write a test and was running into problems where getting the painted surface after doing a double-tap would get one of the intermediate animation frames instead of waiting to the end. I realized I needed to wait until all the paints were done and then grab the screen.

Also this allows fixing a potential race condition in testLoad where the entire screen gets painted after calling loadUrl but before creating the paint expecter.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Fix race condition in testLoad

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 593902 [details] [diff] [review]
Add a blockUntilClear function

Review of attachment 593902 [details] [diff] [review]:
-----------------------------------------------------------------

took me a minute and an IRC chat to figure out what we were doing here.  The comments make sense once I understood that we were waiting for a series of events to transpire.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 593903 [details] [diff] [review]
Fix race condition in testLoad

Review of attachment 593903 [details] [diff] [review]:
-----------------------------------------------------------------

very cool!

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/10aabf337120
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b21642cc621

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/10aabf337120
https://hg.mozilla.org/mozilla-central/rev/6b21642cc621