CTypes prints function types incorrectly. For example: js> ctypes.FunctionType(ctypes.default_abi, ctypes.int).toString() "type int()()" js> It should return "type int()".
Attachment #594054 - Flags: review?(jones.chris.g)
I thought Chris had helped work on CTypes, and thus r?'d him; if that's not correct, apologies; who is best?
Attachment #594054 - Flags: review?(jones.chris.g) → review?(bobbyholley+bmo)
Attachment #594054 - Flags: review?(bobbyholley+bmo) → review+
Revised per bholley's review comments.
Attachment #594054 - Attachment is obsolete: true
Backed out due to test failures on all Windows boxes in test_ctypes.js and test_ctypes.xul. Fwiw, Try didn't really look good ;)
(In reply to Marco Bonardo [:mak] from comment #6) > Fwiw, Try didn't really look good ;) I suck. Thanks, Marco.
Revised to fix Win32 tests (bad spacing for __stdcall and WINAPI qualifiers).
Attachment #594854 - Attachment is obsolete: true
New try run: https://tbpl.mozilla.org/?tree=Try&rev=c327706ed342
(In reply to Jim Blandy :jimb from comment #9) > New try run: https://tbpl.mozilla.org/?tree=Try&rev=c327706ed342 That showed up some more xpcshell test failures. This one is clean: https://tbpl.mozilla.org/?tree=Try&rev=cc27c2c3fa1a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.