Closed
Bug 723863
Opened 12 years ago
Closed 12 years ago
Standalone Message window toolbar doesn't show personas
Categories
(Thunderbird :: Theme, defect)
Tracking
(thunderbird11+ fixed, thunderbird12 fixed)
RESOLVED
FIXED
Thunderbird 13.0
People
(Reporter: standard8, Assigned: Paenglab)
Details
Attachments
(1 file)
1.15 KB,
patch
|
bwinton
:
review+
bwinton
:
ui-review+
standard8
:
approval-comm-aurora+
standard8
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
The toolbar of the standalone message window isn't showing the personas background. On the mac it just has a grey background. The titlebar does show personas, so this looks a little strange.
Assignee | ||
Comment 1•12 years ago
|
||
This patch sets the toolbar's -moz-appearance to toolbar in standalone window only when no persona is enabled. I also removed the gradient with personas enabled which is shown when the appearance isn't toolbar. And I moved the definitions to messageWindow.css where standalone window definitions make more sense (IMHO).
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #594267 -
Flags: ui-review?(bwinton)
Attachment #594267 -
Flags: review?(bwinton)
Comment 2•12 years ago
|
||
Comment on attachment 594267 [details] [diff] [review] Patch Yep, I like it, and it makes sense to me. :) r=me, ui-r=me. Thanks, Blake.
Attachment #594267 -
Flags: ui-review?(bwinton)
Attachment #594267 -
Flags: ui-review+
Attachment #594267 -
Flags: review?(bwinton)
Attachment #594267 -
Flags: review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•12 years ago
|
Attachment #594267 -
Flags: approval-comm-beta?
Attachment #594267 -
Flags: approval-comm-aurora?
Reporter | ||
Comment 3•12 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/96284abe691b
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
Reporter | ||
Updated•12 years ago
|
Attachment #594267 -
Flags: approval-comm-beta?
Attachment #594267 -
Flags: approval-comm-beta+
Attachment #594267 -
Flags: approval-comm-aurora?
Attachment #594267 -
Flags: approval-comm-aurora+
Reporter | ||
Comment 4•12 years ago
|
||
Checked into branches: http://hg.mozilla.org/releases/comm-aurora/rev/02c3bf169c41 http://hg.mozilla.org/releases/comm-beta/rev/5e7669758589
status-thunderbird11:
--- → fixed
status-thunderbird12:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•