Closed Bug 723863 Opened 9 years ago Closed 9 years ago

Standalone Message window toolbar doesn't show personas

Categories

(Thunderbird :: Theme, defect)

All
macOS
defect
Not set
normal

Tracking

(thunderbird11+ fixed, thunderbird12 fixed)

RESOLVED FIXED
Thunderbird 13.0
Tracking Status
thunderbird11 + fixed
thunderbird12 --- fixed

People

(Reporter: standard8, Assigned: Paenglab)

Details

Attachments

(1 file)

The toolbar of the standalone message window isn't showing the personas background. On the mac it just has a grey background.

The titlebar does show personas, so this looks a little strange.
Attached patch PatchSplinter Review
This patch sets the toolbar's -moz-appearance to toolbar in standalone window only when no persona is enabled. I also removed the gradient with personas enabled which is shown when the appearance isn't toolbar.

And I moved the definitions to messageWindow.css where standalone window definitions make more sense (IMHO).
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #594267 - Flags: ui-review?(bwinton)
Attachment #594267 - Flags: review?(bwinton)
Comment on attachment 594267 [details] [diff] [review]
Patch

Yep, I like it, and it makes sense to me.  :)

r=me, ui-r=me.

Thanks,
Blake.
Attachment #594267 - Flags: ui-review?(bwinton)
Attachment #594267 - Flags: ui-review+
Attachment #594267 - Flags: review?(bwinton)
Attachment #594267 - Flags: review+
Keywords: checkin-needed
Attachment #594267 - Flags: approval-comm-beta?
Attachment #594267 - Flags: approval-comm-aurora?
Checked in: http://hg.mozilla.org/comm-central/rev/96284abe691b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
Attachment #594267 - Flags: approval-comm-beta?
Attachment #594267 - Flags: approval-comm-beta+
Attachment #594267 - Flags: approval-comm-aurora?
Attachment #594267 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.