723905 - Some characters throw errors in the Mozilla Phonebook

Status: RESOLVED FIXED

(Webtools Graveyard :: Phonebook, defect)

Description

[Robert Nyman]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:11.0a2) Gecko/20120131 Firefox/11.0a2
Build ID: 20120131042011

Steps to reproduce:

When you do a search in Mozilla Phonebook with certain characters, like () that some names include, you get an LDAP error. Example: https://phonebook.mozilla.org/#search/%28%29


Actual results:

I got a Bad search filter error


Expected results:

Get to see results where the user name contains parentheses

Comment 1

[Fred Wenzel [:wenzel]]

Uuuuugly!

Comment 2

[Fred Wenzel [:wenzel]]

I added proper escaping here: r101073. I borrowed the code from PEAR's Net_LDAP_Util.

Thanks for the bug report, Robert. Note that your search query "()" won't return anything, and "(" will return a lot because it searches in name, email, and IM fields.

Rob Tucker, can you svn up the server and then mark this bug resolved? Thanks!

Comment 3

[Rob Tucker [:rtucker]]

wenzel:
Just pushed it live. 

Updated to revision 101075.

Do you want to test and confirm?

Comment 4

[Fred Wenzel [:wenzel]]

That works fabulously, thanks! The URL in comment 0 is now "nothing found", as expected. I entered a few searches that should return something useful, and those work as well.

Comment 5

[Rob Tucker [:rtucker]]

wenzel++

Comment 6

[Robert Nyman]

Looks great, thanks!
And yes, that was just a basic example with () to show the errors. I found that some users had parentheses in their names, e.g. https://phonebook.mozilla.org/#search/Desigan%20%28Dees%29%20Chinniah, which then threw an error when I wanted to link to them.

Again, thanks for a swift fix!