Layout corruption possibly by table size error.

RESOLVED FIXED in mozilla0.9

Status

()

--
major
RESOLVED FIXED
18 years ago
18 years ago

People

(Reporter: ivo, Assigned: karnaze)

Tracking

({regression})

Trunk
mozilla0.9
x86
Windows 98
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(4 attachments)

(Reporter)

Description

18 years ago
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; 0.8.1) Gecko/20010316
BuildID:    2001031604

Rendered layout of this URL is correct until rendering reaches to last image
(whole rightmost cell of table is abandoned).

Reproducible: Always
Steps to Reproduce:
Load given URL.


Actual Results:  Layout of this page is corrupt, elements from right edge are
abandoned.

Expected Results:  All page elements should fit to window. 

Last image which will destroy layout:
<td><img height="1" width="132" src="/Images/main-horizontal-scroll[1].gif"></td>
Layout will not get corrupt if width is set to less than 132.
(Reporter)

Comment 1

18 years ago
Removed redundant http:// URL.

Comment 2

18 years ago
Confirming on 2001031604 Win2k and over to HTML Tables.
Status: UNCONFIRMED → NEW
Component: Layout → HTMLTables
Ever confirmed: true
QA Contact: petersen → chrisd

Comment 3

18 years ago
Hot potato for you Chris. I backed out my changes from 2001-03-12 21:10 and the
problem still persists. But I have 2001031204 that renders the page correct....
And there was only one additional checkin to tables stuff. :-)
Keywords: regression
(Assignee)

Comment 4

18 years ago
Created attachment 28079 [details]
reduced tests case
(Assignee)

Comment 5

18 years ago
Moving to m0.9
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9
(Assignee)

Comment 6

18 years ago
Created attachment 28080 [details] [diff] [review]
patch to correctly determine min/max widths during cell size change
(Assignee)

Updated

18 years ago
Keywords: patch

Comment 7

18 years ago
 I applied the patch under Win98. It fixes the URL and the testcase. The change
looks quite natural to me. r = bernd
(Assignee)

Comment 8

18 years ago
Created attachment 28173 [details] [diff] [review]
better patch (ignore the previous one)
(Assignee)

Comment 9

18 years ago
Created attachment 28501 [details] [diff] [review]
best patch (ignor others)
QA contact update
QA Contact: chrisd → amar

Comment 11

18 years ago
Is it safe to declare the iteration index in the for() loop on all platforms? I
think some compilers handle this poorly so I'd suggest moving the decl of
PRInt32 out.
 --> for (PRInt32 rowX = 0; rowX < numRows; rowX++) {

Typo in this comment
 -- > // see if the doesn't have a pct width

otherwise, sr=attinasi
(Assignee)

Comment 12

18 years ago
The patch is in.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Reporter)

Comment 13

18 years ago
Win98, 2001032304

Now this page is even worse.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 14

18 years ago
ivo, I have a little older build than you, but do have all of the recent table 
changes, and I'm not seeing the problem on the url or the reduced test case on 
WinNT. If the original problem (image not showing up) has been fixed and there 
is another problem on this page, then another bug should be filed and this one 
should be left closed. Is that the case? 
(Reporter)

Comment 15

18 years ago
Image problem is fixed, but bottom part of this page is abandoned.
(Assignee)

Comment 16

18 years ago
The new problem has been fixed by the patch in bug 73321. It was indeed a 
different problem. Marking this fixed again.
Status: REOPENED → RESOLVED
Last Resolved: 18 years ago18 years ago
Resolution: --- → FIXED

Comment 17

18 years ago
I opened bug 78536 about the rendering differences between mozilla and NN and IE5
You need to log in before you can comment on or make changes to this bug.