The default bug view has changed. See this FAQ.

ImageLayerD3D*.cpp does not compile on mingw

RESOLVED FIXED in mozilla13

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla13
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 594183 [details] [diff] [review]
fix v1.0

GCC doesn't like initializing nsAutoPtr by assignment operator (as it's not the usual assignment). The attached patch changes initialization to use a regular constructor.
Attachment #594183 - Flags: review?
Attachment #594183 - Flags: review? → review?(bas.schouten)
Comment on attachment 594183 [details] [diff] [review]
fix v1.0

Review of attachment 594183 [details] [diff] [review]:
-----------------------------------------------------------------

I prefer the assignment format from a stylistic perspective but if this makes gcc happy!
Attachment #594183 - Flags: review?(bas.schouten) → review+
(Assignee)

Comment 2

5 years ago
Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/deefae783b97
https://hg.mozilla.org/mozilla-central/rev/deefae783b97
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.