Last Comment Bug 723942 - ImageLayerD3D*.cpp does not compile on mingw
: ImageLayerD3D*.cpp does not compile on mingw
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: x86 Windows 7
: -- normal (vote)
: mozilla13
Assigned To: Jacek Caban
:
: Milan Sreckovic [:milan]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-03 07:46 PST by Jacek Caban
Modified: 2012-02-07 12:20 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix v1.0 (3.14 KB, patch)
2012-02-03 07:46 PST, Jacek Caban
bas: review+
Details | Diff | Splinter Review

Description Jacek Caban 2012-02-03 07:46:44 PST
Created attachment 594183 [details] [diff] [review]
fix v1.0

GCC doesn't like initializing nsAutoPtr by assignment operator (as it's not the usual assignment). The attached patch changes initialization to use a regular constructor.
Comment 1 Bas Schouten (:bas.schouten) 2012-02-05 07:41:24 PST
Comment on attachment 594183 [details] [diff] [review]
fix v1.0

Review of attachment 594183 [details] [diff] [review]:
-----------------------------------------------------------------

I prefer the assignment format from a stylistic perspective but if this makes gcc happy!
Comment 2 Jacek Caban 2012-02-06 02:28:00 PST
Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/deefae783b97
Comment 3 Ed Morley [:emorley] 2012-02-07 12:20:20 PST
https://hg.mozilla.org/mozilla-central/rev/deefae783b97

Note You need to log in before you can comment on or make changes to this bug.