Closed
Bug 723942
Opened 13 years ago
Closed 13 years ago
ImageLayerD3D*.cpp does not compile on mingw
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
|
3.14 KB,
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
GCC doesn't like initializing nsAutoPtr by assignment operator (as it's not the usual assignment). The attached patch changes initialization to use a regular constructor.
Attachment #594183 -
Flags: review?
|
||
Updated•13 years ago
|
Attachment #594183 -
Flags: review? → review?(bas.schouten)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 594183 [details] [diff] [review]
fix v1.0
Review of attachment 594183 [details] [diff] [review]:
-----------------------------------------------------------------
I prefer the assignment format from a stylistic perspective but if this makes gcc happy!
Attachment #594183 -
Flags: review?(bas.schouten) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
Thanks for the review.
https://hg.mozilla.org/integration/mozilla-inbound/rev/deefae783b97
|
||
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•