Closed Bug 723984 Opened 9 years ago Closed 9 years ago

PageInfo->Permissions: Don't assume that the whitelist pref is there. It defaults to true in the new add-ons manager code. Don't assume all consumers use testPermission.

Categories

(SeaMonkey :: Page Info, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: philip.chee, Assigned: philip.chee)

Details

Attachments

(1 file)

See Firefox bugs:
Bug 560602: browser_pageInfo.js times out.
  "also stops assuming that the whitelist pref is there, it defaults to true in the new add-ons manager code."

Bug 655869 - Permissions tab assumes all consumers use testPermission.
Attached patch Patch v1.0Splinter Review
> Bug 560602: browser_pageInfo.js times out.
>   "also stops assuming that the whitelist pref is there, it defaults to true in the new add-ons manager code."
We copied the browser_pageInfo.js test but renamed it browser_feed_tab.js

> Bug 655869 - Permissions tab assumes all consumers use testPermission.
Tested Permissions tab with
http://benwerd.com/lab/geo.php
vs.
http://www.benwerd.com/lab/geo.php

> +++ b/suite/browser/test/browser/browser_feed_tab.js
> @@ -1,34 +1,33 @@
> +// originally from m-c/browser/base/content/test/browser_pageInfo.js.
Left a note in case someone else wastes his time (like I did) thinking we
need to port browser_pageInfo.js again.

Also synced the latest changes from browser_pageInfo.js.
Attachment #594411 - Flags: review?(neil)
Attachment #594411 - Flags: review?(neil) → review+
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/765a0a88867a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.