The default bug view has changed. See this FAQ.

java.lang.NullPointerException: at org.mozilla.gecko.GeckoEvent.addMotionPoint(GeckoEvent.java)

VERIFIED FIXED in Firefox 11

Status

()

Firefox for Android
General
P1
critical
VERIFIED FIXED
5 years ago
3 years ago

People

(Reporter: Scoobidiver (away), Assigned: wesj)

Tracking

({crash, regression, topcrash})

13 Branch
Firefox 13
ARM
Android
crash, regression, topcrash
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed, firefox13 verified, fennec11+)

Details

(Whiteboard: [native-crash][startupcrash], crash signature)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

5 years ago
It's a startup crash so far.
It first appeared in 13.0a1/20120202155221 on Feb 3rd with various devices.

The regression range might be (hard to determine for a startup crash and might be the result of Socorro 2.4.1):
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5b0900b3e71c&tochange=e777c939a3f9

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A%20at%20org.mozilla.gecko.GeckoEvent.addMotionPoint%28GeckoEvent.java%29
(Reporter)

Updated

5 years ago
Crash Signature: [@ java.lang.NullPointerException: at org.mozilla.gecko.GeckoEvent.addMotionPoint(GeckoEvent.java)] → [@ java.lang.NullPointerException: at org.mozilla.gecko.GeckoEvent.addMotionPoint(GeckoEvent.java)] [@ java.lang.NullPointerException: at org.mozilla.gecko.GeckoEvent.addMotionPoint(GeckoEvent.java) ]

Comment 1

5 years ago
wes, this is probably yours.  any idea what could be throwing?  Can you bullet proof or wrap with a try and prevent the exit()?
Assignee: nobody → wjohnston

Updated

5 years ago
tracking-fennec: --- → 11+
Priority: -- → P1
Keywords: topcrash
(Assignee)

Comment 2

5 years ago
Created attachment 594764 [details] [diff] [review]
Workaround patch

I'm not sure if this is to broad a try-catch. I'm also not exactly sure what the problem is here without more info. Potentially we don't have GeckoApp.mAppContext.getLayerController() or eckoApp.mAppContext.getWindowManager() yet?

Trying to reproduce...
Attachment #594764 - Flags: review?(doug.turner)
(Assignee)

Comment 3

5 years ago
Comment on attachment 594764 [details] [diff] [review]
Workaround patch

Looking at this a bit more first...
Attachment #594764 - Flags: review?(doug.turner)
(Assignee)

Comment 4

5 years ago
Created attachment 595120 [details] [diff] [review]
Patch

Ok. Still can't reproduce this. Dougt, is this the kind of protection you'd want, or I can wrap the calls into

GeckoApp.mAppContext.getLayerController() and 
GeckoApp.mAppContext.getWindowManager().getDefaultDisplay()

which seem more likely to be causing this (I'm not sure how we'd get to the point of calling addMotionPoint if the event is empty).
Attachment #594764 - Attachment is obsolete: true
Attachment #595120 - Flags: review?(doug.turner)

Comment 5

5 years ago
Comment on attachment 595120 [details] [diff] [review]
Patch

Review of attachment 595120 [details] [diff] [review]:
-----------------------------------------------------------------

I'd put the try inside of the method so that it can never throw.  r+ w/ that change.
Attachment #595120 - Flags: review?(doug.turner) → review+
Talked to Laura, and figured out how to get the Java stack from Socorro:

Java stack : 
java.lang.NullPointerException
	at org.mozilla.gecko.GeckoEvent.addMotionPoint(GeckoEvent.java:198)
	at org.mozilla.gecko.GeckoEvent.<init>(GeckoEvent.java:178)
	at org.mozilla.gecko.GeckoAppShell$2.onTouch(GeckoAppShell.java:509)
	at org.mozilla.gecko.gfx.LayerController.onTouchEvent(LayerController.java:404)
	at org.mozilla.gecko.gfx.LayerView.onTouchEvent(LayerView.java:112)
	at android.view.View.dispatchTouchEvent(View.java:5541)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1957)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1684)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1957)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1684)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1957)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1684)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1957)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1684)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1957)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1684)
	at com.android.internal.policy.impl.PhoneWindow$DecorView.superDispatchTouchEvent(PhoneWindow.java:1912)
	at com.android.internal.policy.impl.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1371)
	at android.app.Activity.dispatchTouchEvent(Activity.java:2364)
	at com.android.internal.policy.impl.PhoneWindow$DecorView.dispatchTouchEvent(PhoneWindow.java:1860)
	at android.view.View.dispatchPointerEvent(View.java:5721)
	at android.view.ViewRootImpl.deliverPointerEvent(ViewRootImpl.java:2890)
	at android.view.ViewRootImpl.handleMessage(ViewRootImpl.java:2466)
	at android.view.ViewRootImpl.processInputEvents(ViewRootImpl.java:845)
	at android.view.ViewRootImpl.handleMessage(ViewRootImpl.java:2475)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:137)
	at org.mozilla.gecko.GeckoApp$32.run(GeckoApp.java:1777)
	at android.os.Handler.handleCallback(Handler.java:605)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4424)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
	at dalvik.system.NativeStart.main(Native Method)
(Assignee)

Comment 7

5 years ago
Created attachment 595184 [details] [diff] [review]
Patch

Sorry for the churn dougt. I'm a bit nervous my old try catch could lead to having mPoints = [null, null, null...] which i don't think would go over well in C++. This initializes them to Point(0,0) in the catch.
Attachment #595120 - Attachment is obsolete: true
Attachment #595184 - Flags: review?(doug.turner)

Updated

5 years ago
Attachment #595184 - Flags: review?(doug.turner)
Attachment #595184 - Flags: review+
Attachment #595184 - Flags: approval-mozilla-beta+
Attachment #595184 - Flags: approval-mozilla-aurora+
(Assignee)

Comment 8

5 years ago
i'll push to aurora in the morning assuming there's no issues on inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b1fad0b7354
https://hg.mozilla.org/mozilla-central/rev/0b1fad0b7354
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
(Reporter)

Comment 10

5 years ago
There are no crashes in 13.0a1/20120209.
status-firefox13: --- → verified
(Assignee)

Comment 11

5 years ago
I put this in the patch queue for Aurora and beta (although its currently bitrotted in both). dougt, are we using the patch queues anymore, or should i just unbitrot and push?
unrot and push ;-D
(Reporter)

Updated

5 years ago
status-firefox11: --- → affected
status-firefox12: --- → affected
(Reporter)

Comment 13

5 years ago
It's #1 top crasher in 12.0a2. Is it possible to push it in Aurora and Beta?
(Assignee)

Comment 14

5 years ago
Whoops. Yep. Will push when i get in in an hour. Thanks for the reminder.
(Assignee)

Comment 15

5 years ago
http://hg.mozilla.org/releases/mozilla-aurora/rev/f1319928a26a
status-firefox12: affected → fixed
(Assignee)

Comment 16

5 years ago
http://hg.mozilla.org/releases/mozilla-beta/rev/7571a84c7ec8
status-firefox11: affected → fixed
Closing bug as verified fixed regarding comment #10
Status: RESOLVED → VERIFIED

Comment 18

5 years ago
Just crashed like bp-fc8ee5ac-bf54-4568-b55e-852d42120329 on yesterday's Nightly of Fennec
Is this a regression?
(Reporter)

Comment 19

5 years ago
(In reply to alex_mayorga from comment #18)
> Is this a regression?
You were using 13.0a1/20120206031148 (1.5 month old) while the latest version is 14.0a1/20120329031156. Please upgrade if you want to help debug.
Comment hidden (spam)
You need to log in before you can comment on or make changes to this bug.