Closed
Bug 724429
Opened 13 years ago
Closed 13 years ago
use getBrowserURL() instead of hardcoded browser chrome URL
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: heycam, Unassigned)
Details
Attachments
(1 file)
|
5.29 KB,
patch
|
dao
:
review-
|
Details | Diff | Splinter Review |
Seems better to use the function if we can, so there are fewer places with the
hardcoded string.
|
Reporter | |
Comment 1•13 years ago
|
||
|
|
Reporter | |
Updated•13 years ago
|
Attachment #594600 -
Flags: review?(dao)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 594600 [details] [diff] [review]
Use getBrowserURL() instead of hardcoded browser chrome URL.
>--- a/browser/components/places/src/PlacesUIUtils.jsm
>+++ b/browser/components/places/src/PlacesUIUtils.jsm
>- browserWindow = Services.ww.openWindow(aWindow,
>- "chrome://browser/content/browser.xul",
>- null, "chrome,dialog=no,all", args);
>+ browserWindow = Services.ww.openWindow(aWindow, getBrowserURL(), null,
>+ "chrome,dialog=no,all", args);
I don't think getBrowserURL exists here.
Not sure if this is useful at all. I wouldn't want to encourage other places to load utilityOverlay.js just to get getBrowserURL.
Attachment #594600 -
Flags: review?(dao) → review-
|
|
Reporter | |
Comment 3•13 years ago
|
||
OK.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•