724514 - xplat build: add rules for generating avmfeatures if AVM defined

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Build Config, defect)

Description

[Felix S. Klock II [:pnkfelix, :fklock]]

In the same vein as Bug 632857 and Bug 719011: make correct [re]building the avmshell easier by adding rules to reprocess avmfeatures.as if we have an avmshell available (as indicated by setting the AVM environment variable).

(Like Bug 632857, maintain current status quo by making the rules no-op if AVM is unset.)

Comment 1

[Felix S. Klock II [:pnkfelix, :fklock]]

It would be nice if we only needed to have AVM defined to process avmfeatures.as, but right now that is blocked by Bug 602046.

So in short term the simplest way to address that is to check if AVM and ASC are both defined, and only then attempt to process avmfeatures.as.  (This also generally requires checking for JAVA_HOME in the same way that the exactgc.py script does.)

Comment 2

[Felix S. Klock II [:pnkfelix, :fklock]]

Attachment: patch A: if AVM+ASC set and avmfeatures.as newer than avmfeatures.h, regen

Comment 3

[Felix S. Klock II [:pnkfelix, :fklock]]

Attachment: patch A v2: if AVM+ASC set and avmfeatures.as newer than avmfeatures.h, regen

(small comment revision to the drive-by doc/comment updates in the two manifest.mk files.)

Comment 4

[Felix S. Klock II [:pnkfelix, :fklock]]

(I suspect I'm the only one who cared about this.  If someone else wants to pick this up, go ahead and reopen.)