xplat build: add rules for generating avmfeatures if AVM defined

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
7 years ago
6 years ago

People

(Reporter: pnkfelix, Unassigned)

Tracking

(Blocks: 1 bug)

Details

Attachments

(1 attachment, 1 obsolete attachment)

In the same vein as Bug 632857 and Bug 719011: make correct [re]building the avmshell easier by adding rules to reprocess avmfeatures.as if we have an avmshell available (as indicated by setting the AVM environment variable).

(Like Bug 632857, maintain current status quo by making the rules no-op if AVM is unset.)
(Reporter)

Updated

7 years ago
Assignee: nobody → fklockii
It would be nice if we only needed to have AVM defined to process avmfeatures.as, but right now that is blocked by Bug 602046.

So in short term the simplest way to address that is to check if AVM and ASC are both defined, and only then attempt to process avmfeatures.as.  (This also generally requires checking for JAVA_HOME in the same way that the exactgc.py script does.)
Created attachment 594744 [details] [diff] [review]
patch A: if AVM+ASC set and avmfeatures.as newer than avmfeatures.h, regen
Created attachment 594747 [details] [diff] [review]
patch A v2: if AVM+ASC set and avmfeatures.as newer than avmfeatures.h, regen

(small comment revision to the drive-by doc/comment updates in the two manifest.mk files.)
Attachment #594744 - Attachment is obsolete: true
(Reporter)

Updated

7 years ago
Attachment #594747 - Flags: feedback?(brbaker)
(Reporter)

Updated

7 years ago
Blocks: 724695
(I suspect I'm the only one who cared about this.  If someone else wants to pick this up, go ahead and reopen.)
Assignee: fklockii → nobody
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WONTFIX
(Reporter)

Updated

6 years ago
Attachment #594747 - Flags: feedback?(brbaker)
You need to log in before you can comment on or make changes to this bug.