Closed Bug 724740 Opened 8 years ago Closed 8 years ago

Reparent children during bookmark folder deletion

Categories

(Firefox for Android :: Android Sync, defect, P1)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
mozilla14
Tracking Status
blocking-fennec1.0 --- beta+

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

(Whiteboard: [sync])

Blocks the full version of Bug 723841.
Blocks: 718154
Reasoning: if we process a deleted folder before we process all of its deleted children, then the deletion will fail due to consistency constraints, and the sync as a whole will fail. We need to queue deletions (Bug 724739), and handle the case of a folder being deleted without all of its children being deleted (this bug).
blocking-fennec1.0: --- → beta+
Whiteboard: [sync]
Assignee: nobody → ally
Assignee: ally → rnewman
Status: NEW → ASSIGNED
This is nearly done (and also Bug 724739); just writing tests now.
Tests pass. Running a build to get some QA before I land this, because I don't want to have to back it out!
How do you delete a folder without deleting its children?
rnewman, please post the snippet you use to delete folder without touching its children.
(In reply to Tracy Walker [:tracy] from comment #6)
> rnewman, please post the snippet you use to delete folder without touching
> its children.

https://wiki.mozilla.org/Services/Sync/Snippets#Delete_and_restore_a_record
ok, got that working (I think).  Now, what am I looking for on the mobile device or in logs?
https://hg.mozilla.org/mozilla-central/rev/1c2a06f36ba3

Not sure if I'm supposed to close this bug or not.
Thanks Ehsan!
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Product: Mozilla Services → Android Background Services
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.