724896 - Replace search keywords with their respective domain name when showing autocomplete suggestions (Awesome bar suggestions, not inline-autocomplete)

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, defect, P5)

Description

[Reuben Morais [:reuben]]

If I have the "yt" search keyword set to YouTube search, I'd like to type "yt something" on the Awesome Bar and see YouTube history/bookmarks on the autocomplete suggestions.

Comment 1

[Reuben Morais [:reuben]]

Attachment: First attempt at a solution.

This technically works, and does exactly what I intended it to do, but my hack-o-meter is buzzing loudly about this patch. Attaching as a WIP.

ATM it excludes all suggestions that aren't in the same domain as the search engine (if I set 'bug' as the keyword for b.m.o., I won't see results from bug.com). This is the behavior I want, but might need some UX discussion. Or maybe not? After all, search keywords are a deeply hidden feature.

Comment 2

[Marco Bonardo [:mak]]

I think that typing a search keyword and returning only results limited to that particular page could surprise users, also cause the keyword functionality is expected be used to run a remote search.
Though, there isn't an expected outcome from search keywords in the locationbar as of now, so this could be one of those, it depends on what will happen when the bars will be eventually merged.

Comment 3

[Reuben Morais [:reuben]]

Note that this is the behavior for the "Add a Keyword for this Search" feature, only pages in the same domain are shown in the result list: http://cl.ly/image/3N120i1S3l1x

Comment 4

[Reuben Morais [:reuben]]

Ugh, disregard that, other things are shown when there are less history entries matching what you typed.

Comment 5

[Marco Bonardo [:mak]]

yes, only the first entry is used for bookmarks keywords.

Comment 6

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.

Comment 7

[Marco Bonardo [:mak]]

This has been superseded by the work on search mode, in particular search mode for non-general search engines restricts searches to that origin. It doesn't yet work for bookmark keywords, but there are plans for that.