test_bug720538 fails on some screen sizes

VERIFIED FIXED in Firefox 13

Status

()

Firefox for Android
General
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

unspecified
Firefox 13
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: not-fennec-11)

Attachments

(1 attachment)

Created attachment 595057 [details] [diff] [review]
Patch

On some devices test_bug720538 fails because the screen is large enough to include the iframe in the bottom-right corner, messing up the pixel check. The pixel check isn't technically needed, so we can just take it out.
Attachment #595057 - Flags: review?(jmaher)
Comment on attachment 595057 [details] [diff] [review]
Patch

Review of attachment 595057 [details] [diff] [review]:
-----------------------------------------------------------------

looks good to me.  Any danger in this failing on a different screen size for the one pixel we still are checking?
Attachment #595057 - Flags: review?(jmaher) → review+
I don't think the remaining pixel check can fail on a different screen size; the other iframe is way off to the right. The only other thing in that area is the scrollbar which might interfere but would do so consistently across all devices and would have showed up in my testing.

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/7c7041f59ef5
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 5

6 years ago
Verified on:
Nightly Fennec 13.0a1 (2012-03-04)
Device: HTC Desire Z
OS: Android 2.3.3
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.