724963 - port bug 728813 - Restart in normal mode (add-ons enabled) in help menu when in safe-mode

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, enhancement)

Description

[Cecil Westerhof]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0.1) Gecko/20100101 Firefox/9.0.1
Build ID: 20111220165912

Steps to reproduce:

I started Thunderbird in safe-mode.


Actual results:

There is an entry in the help menu about restarting in safe-mode.


Expected results:

The entry should be about restarting in normal mode.

Comment 1

[Hashem Masoud]

(In reply to Cecil Westerhof from comment #0)
The entry in Linux is different "Restart with Add-ons disabled". 

The behavior is that once you hit that menu option, you get a dialog window in which you can choose "Continue in safe mode". Once you hit that button, Thunderbird starts in safe mode. Once you exit Thunderbird and start it again, it starts in normal mode.

Comment 2

[Cecil Westerhof]

I think I wrote it not complete correct. In Windows the menu entry is the same, but when restarted it says the "Continue in safe mode".

But what I mean is the following: when I am working in save mode then the menu entry "Restart with Add-ons disabled" has no use.

Comment 3

[Hashem Masoud]

(In reply to Cecil Westerhof from comment #2)
> But what I mean is the following: when I am working in save mode then the
> menu entry "Restart with Add-ons disabled" has no use.

Agreed, this is misleading.

Comment 4

[Wayne Mery (:wsmwk)]

(In reply to Hashem Masoud from comment #3)
> (In reply to Cecil Westerhof from comment #2)
> > But what I mean is the following: when I am working in save mode then the
> > menu entry "Restart with Add-ons disabled" has no use.
> 
> Agreed, this is misleading.

I disagree. The primary purpose of restart (and other items) from the help menu is to help the user in doing some non-standard tasks.  And it's certainly possible a user may want to restart thunderbird *again* in safe mode.

So I don't think we should be offering a "normal mode start" in this location, both for consistency and for the fact that Thunderbird currently doesn't offer anywhere "normal mode start" from a menu.
Plus consitency with Firefox (which I acknowledge some may consider a non-starter)
=> wontfix?

Comment 5

[Wayne Mery (:wsmwk)]

hmm, Bug 728813 - In safe-mode, Help -> Restart with Add-ons Disabled should switch to something to allow restarting in normal mode - is implemented/fixed for Firefox 40. (Bug 1194744 still open for Seamonkey)

But I still disagree with the premise, and the result. And it seems like extra code to maintain.

Comment 6

[Richard Marti (:Paenglab)]

I'm okay with not implementing this bug. This is a normally seldom used menu entry.

Comment 8

[Ton [:Tonnes]]

Times have changed a bit for Safe mode so I don’t see why the menu item should not be changed with the same purpose bug 728813 had for Firefox, so this would be for consistency (call it a habit for users if you like) and the fact that the menu item is one of two advised ways of starting in Safe mode. When in Safe mode, the item doesn’t make sense now (looking unfinished IMO and implying some loop) and users need to restart manually in order to return, requiring more actions to take. Some may even wonder how to return to normal mode. I did.

The only reason not to do so (yet) would be the Safe mode dialog still offering the "Reset toolbars and controls" option that was removed for FF, but I don’t think that’s an option to choose from within Safe mode as a second troubleshooting step.

Comment 9

[Wayne Mery (:wsmwk)]

Looks easy and I withdraw my objections.
Richard is this something you can do?

Comment 10

[Richard Marti (:Paenglab)]

Attachment: 724963-restart-in-normal-mode.patch

Port of https://hg.mozilla.org/mozilla-central/rev/e1afdf84febb

Comment 11

[Magnus Melin [:mkmelin]]

Comment on attachment 9074585 [details] [diff] [review]
724963-restart-in-normal-mode.patch

Review of attachment 9074585 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d714bac9fcfa
Port bug 728813: Restart in safe-mode in help menu when in safe-mode. r=mkmelin