72498 - no "File Here" in file menu

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P1)

Description

[(not reading, please use [e-mail] instead)]

same goes for Copy and Move.

instead, I get a thin, blank area where it used to say "File Here"

Comment 1

[Eric Vaandering (no email)]

This regressed sometime between 0.8 and March 14 (I know, a big window).

Comment 2

[(not reading, please use [e-mail] instead)]

bhuvan has a fix for this in his local tree.

Comment 3

[racham]

Attachment: patch to resurrect 'File Here' (equivalent) labels

Comment 4

[racham]

Adding Gayatri to cc list.

This is patch is similar to the one posted in bug 71096 (which never made it to 
081 branch). This patch is now trunk specific (with 'label' replacing 'value').
Gayatri and Seth already reviewed patch in bug 71096. Thanks for reviews and 
comments then.

Here are the only new things that I added this time.

* In msgFolderPickerOverlay.js, I had to replace one instance of 'value' to 
'label' (this change is very much needed to make things work as expected)

* Added menu-iconic and menuitem-iconic in couple of places in 
messengercompose.xul so that folder icons show up next to folders.

Gayatri & Seth, I need r= & sr= one more time. Thanks.

Comment 5

[scottputterman]

maring nsbeta1+

Comment 6

[racham]

*** Bug 71096 has been marked as a duplicate of this bug. ***

Comment 7

[racham]

Gayatri is on leave. Adding David to cc list for review. thanks.

Comment 8

[David :Bienvenu]

r=bienvenu - I look forward to getting this back :-)

Comment 9

[(not reading, please use [e-mail] instead)]

sr=sspitzer

Comment 10

[racham]

Marking Fixed.

Comment 11

[Ninoschka Baca]

Should this also fix "File Here" not appearing:
- when using the context menu for Copy or Move?
- in the Copies and Folders cascanding menus?

Comment 12

[racham]

Here is the list of the places to be checked inorder to verify this fix.

* ThreadPane Context - Move and Copy Message
* MessagePane Context - Move and Copy Message
* Message Menu item - Move and Copy Message
* Toolbar FileButton 
* Copies and Folders - Fcc, Drafts, Templates
* New Folder Creation (choosing parent folder)
* Search Dialog Picker
* Filter Editor Folder Picker (New/Edit filter)
* Compose window : Options->File Sent Message

Comment 13

[Ninoschka Baca]

Build 2001-04-02-04: NT4
Build 2001-04-02-08: Linux RH 6.2, Mac 9.04
Verified Fixed. I checked the areas that racham suggested.