Closed Bug 725224 Opened 10 years ago Closed 10 years ago

printf SEGV when passing NULL string on Solaris 10 in icalparser.c

Categories

(Calendar :: Internal Components, defect)

Product:
Calendar
Component:
Internal Components
Platform:
All
Solaris
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

Details

(Whiteboard: [libical-upstream?])

Attachments

(1 file)

patch
932 bytes, patch
Fallen
: review+
Details | Diff | Splinter Review 
On Solaris 10, printf("%s", 0) will cause SEGV.

In icalparser.c, icalproperty_kind_to_string() returns 0 and caused SEGV with Gloda enabled.
Attached patch patch — — Splinter Review
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #595335 - Flags: review?(philipp)
Pushed to comm-central changeset e8afafcf0a12
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
Backported to releases/comm-aurora changeset 8811915b46f3
Target Milestone: 1.5 → 1.4
Backported to releases/comm-beta changeset e5f48721a629
Target Milestone: 1.4 → 1.3
(In reply to Philipp Kewisch [:Fallen] from comment #3)
> Pushed to comm-central changeset e8afafcf0a12

r+ is missing1 ;)
Whiteboard: [libical-upstream?]
Comment on attachment 595335 [details] [diff] [review]
patch

My bad :)
Attachment #595335 - Flags: review?(philipp) → review+
You need to log in before you can comment on or make changes to this bug.