Closed Bug 725231 Opened 12 years ago Closed 4 years ago

Remove linker workarounds for breakpad

Categories

(Core :: mozglue, defect)

ARM
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(2 files, 3 obsolete files)

Once bug 689178 is fixed, we won't need the linker to call report_mapping when loading libraries.
Assignee: nobody → mh+mozilla
Attachment #595354 - Flags: review?(taras.mozilla)
Attachment #595354 - Flags: review?(taras.mozilla) → review+
Summary: Stop calling report_mapping from the linker → Remove linker workarounds for breakpad
This removes another workaround for breakpad
Attachment #598796 - Flags: review?(taras.mozilla)
Attachment #595354 - Attachment is obsolete: true
Attachment #598796 - Flags: review?(taras.mozilla) → review+
Forgot to remove the ~_MappableBuffer part.
Attachment #598796 - Attachment is obsolete: true
Comment on attachment 630898 [details] [diff] [review]
Remove linker workarounds for breakpad.

Carrying over r+.
Attachment #630898 - Flags: review+
Refreshed against current m-c
Attachment #630898 - Attachment is obsolete: true
Comment on attachment 745864 [details] [diff] [review]
Remove linker workarounds for breakpad.

Carrying over r+
Attachment #745864 - Flags: review+

This is a rebase of a 7-year-old patch that was r=taras. Back then it
was waiting for breakpad changes that never were reviewed. However,
since then, bug 1486524 made the linker always map uncompressed files
directly, making it less necessary to report the library mappings to
the crash reporter, and bug 1291377 disabled the linker altogether on
Android 6.0+, which makes report_mapping unused at all in that case.

Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/1e893a16cad3
Stop reporting library mappings to the crash reporter. r=snorp
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: