Closed Bug 725249 Opened 12 years ago Closed 12 years ago

intermittent browser/devtools/debugger/test/browser_dbg_propertyview-08.js | Test timed out

Categories

(DevTools :: Debugger, defect, P2)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 14

People

(Reporter: mak, Assigned: vporof)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

v2
3.21 KB, patch
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=9174560&tree=Firefox

There is a bunch of logging, though I'm nto sure which of it is useful, someone that better knows these tests may please check?
I took a look at the log and nothing obvious stands out. Either EventUtils.synthesizeMouseAtCenter isn't fired for some reason, or gc'ing dead windows from previous tests blocks the test from moving on for 30''.

I'll see if I can add more debugging output in the test in case this happens again.
Priority: -- → P2
Assignee: nobody → past
Status: NEW → ASSIGNED
Assignee: past → vporof
Attached patch v1 (obsolete) — — Splinter Review 
I don't really know what's happening here. There's virtually no logging. Added a patch with tons of dumps and a thing I suspect may fix the orange.
Attachment #611406 - Flags: review?(past)
Attachment #611406 - Attachment is patch: true
(In reply to Victor Porof from comment #25)
> Created attachment 611406 [details] [diff] [review]
> v1
> 
> I don't really know what's happening here. There's virtually no logging.
> Added a patch with tons of dumps and a thing I suspect may fix the orange.

https://tbpl.mozilla.org/?tree=Try&rev=a629ba3ff59a
Comment on attachment 611406 [details] [diff] [review]
v1

Review of attachment 611406 [details] [diff] [review]:
-----------------------------------------------------------------

I'm cool with the dumps, but time and again we've been asked during reviews to change sendMouseEvent to synthesizeMouse, so I don't think this is it. That said, there's no harm in seeing what this patch can tell us.
Attachment #611406 - Flags: review?(past) → review+
(In reply to Panos Astithas [:past] from comment #27)
> Comment on attachment 611406 [details] [diff] [review]
> v1
> 
> Review of attachment 611406 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'm cool with the dumps, but time and again we've been asked during reviews
> to change sendMouseEvent to synthesizeMouse, so I don't think this is it.
> That said, there's no harm in seeing what this patch can tell us.

I've actually seen synthesizeMouseAtCenter misbehave badly a number of times. Moreover, the only difference between this and dbg_propertyview-07.js test is the way we send the mouse click event to the content window button. From what I made sense out of the logs, we weren't' even getting to the first       is(gDebugger.StackFrames.activeThread.state, "paused") check, although the test was identical dbg_propertyview-07.js up to that point. Who knows, let's see what happens :)
Whiteboard: [orange] → [orange][land-in-fx-team]
this doesn't apply cleanly.
Attached patch v2 — — Splinter Review 
hg, u so silly.
Attachment #611406 - Attachment is obsolete: true
https://hg.mozilla.org/integration/fx-team/rev/2db0e35d654d
Whiteboard: [orange][land-in-fx-team] → [orange][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/2db0e35d654d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [orange][fixed-in-fx-team] → [orange]
Target Milestone: --- → Firefox 14
Whiteboard: [orange]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: