Closed
Bug 725255
Opened 14 years ago
Closed 14 years ago
Improve checkerboarding telemetry
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 13
People
(Reporter: cwiiis, Assigned: cwiiis)
Details
Attachments
(1 file, 1 obsolete file)
|
5.20 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
Though the patches I submitted in bug 717349 worked fine, they were not particularly good for measuring checkerboarding in practice.
This patch makes both the measurement and the test more effective:
- It changes Robotium to report on the average 'completeness' of rendering, instead of the amount of frames with checkerboard.
- It changes testCheck to pan in a more humanly-possible way, and to change direction.
The numbers I get from this are now useful to improve checkerboarding.
| Assignee | ||
Comment 1•14 years ago
|
||
Attachment #595362 -
Flags: review?(jmaher)
| Assignee | ||
Comment 2•14 years ago
|
||
And with the commit message, sorry for the spam.
Attachment #595362 -
Attachment is obsolete: true
Attachment #595362 -
Flags: review?(jmaher)
Attachment #595365 -
Flags: review?(jmaher)
Comment 3•14 years ago
|
||
Comment on attachment 595365 [details] [diff] [review]
Improve checkerboard metrics
Review of attachment 595365 [details] [diff] [review]:
-----------------------------------------------------------------
this looks good. I have a patch in bug 725055 which will conflict with this one.
Attachment #595365 -
Flags: review?(jmaher) → review+
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•