Unprefix Blob.mozSlice

RESOLVED FIXED in mozilla13

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Simon Pieters, Assigned: mjschranz)

Tracking

({dev-doc-complete})

Trunk
mozilla13
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

5 years ago
User Agent: Opera/9.80 (Macintosh; Intel Mac OS X 10.7.2; U; en) Presto/2.10.229 Version/11.61

Steps to reproduce:

Please rename Blob.mozSlice to Blob.slice. Opera is working on changing the semantics of Blob.slice, but we don't want to prefix it. Since Gecko and WebKit have been shipping without Blob.slice support for several months, the existing content, if any, that relied on the old semantics of Blob.slice have had the chance to break and get updated. With Opera soon shipping Blob.slice with the new semantics, it's time to drop the prefix.
Status: UNCONFIRMED → NEW
Ever confirmed: true
I think we should do this.
I agree!
(Assignee)

Updated

5 years ago
Assignee: nobody → schranz.m
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 3

5 years ago
Created attachment 596057 [details] [diff] [review]
Proposed patch removing moz prefix

I imagine I might need to fix some of the current tests for this too, but I wanted to make sure the changes in the code were correct first before doing so.
Attachment #596057 - Flags: review?(jonas)
Comment on attachment 596057 [details] [diff] [review]
Proposed patch removing moz prefix

Review of attachment 596057 [details] [diff] [review]:
-----------------------------------------------------------------

You need to update tests too. r=me once you do.

::: content/base/public/nsIDOMFile.idl
@@ +59,5 @@
>  interface nsIURI;
>  interface nsIPrincipal;
>  interface nsIDOMBlob;
>  
> +[scriptable, builtinclass, uuid(6640c2aa-fac0-497f-ba0f-60506f9a489f)]

This change doesn't affect the binary signature, so no need to rev the IID.
Attachment #596057 - Flags: review?(jonas) → review+

Updated

5 years ago
Keywords: dev-doc-needed
(Assignee)

Comment 5

5 years ago
Created attachment 596234 [details] [diff] [review]
Proposed patch removing moz prefix

Should cover it.
Attachment #596057 - Attachment is obsolete: true
Attachment #596234 - Flags: review+
(Assignee)

Comment 6

5 years ago
You know, might have used the wrong command there when renaming the file. Let me know if that causes an issue.
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Yeah, we'd prefer to keep the history. If you use "hg mv oldname newname" that should produce a better diff.
And it'll make reviewing easier :)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Comment 9

5 years ago
Created attachment 597682 [details] [diff] [review]
Proposed patch removing moz prefix

Simply forgot a flag I need when generating patches with git!
Attachment #596234 - Attachment is obsolete: true
Attachment #597682 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Duplicate of this bug: 727576
http://hg.mozilla.org/integration/mozilla-inbound/rev/1f99e7a087c1
Keywords: checkin-needed
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → mozilla13
http://hg.mozilla.org/integration/mozilla-inbound/rev/23a142cb2fc1
https://hg.mozilla.org/mozilla-central/rev/23a142cb2fc1
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
and https://hg.mozilla.org/mozilla-central/rev/1f99e7a087c1

Comment 15

5 years ago
Do you need verification that the bug is fixed? I am more than willing to do it.

Updated

5 years ago
Depends on: 732709
Docs updated:

https://developer.mozilla.org/en/DOM/Blob

Added to Firefox 13 for developers.
Keywords: dev-doc-needed → dev-doc-complete
Depends on: 757284
You need to log in before you can comment on or make changes to this bug.