725289 - Unprefix Blob.mozSlice

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Simon Pieters [:zcorpan]]

User Agent: Opera/9.80 (Macintosh; Intel Mac OS X 10.7.2; U; en) Presto/2.10.229 Version/11.61

Steps to reproduce:

Please rename Blob.mozSlice to Blob.slice. Opera is working on changing the semantics of Blob.slice, but we don't want to prefix it. Since Gecko and WebKit have been shipping without Blob.slice support for several months, the existing content, if any, that relied on the old semantics of Blob.slice have had the chance to break and get updated. With Opera soon shipping Blob.slice with the new semantics, it's time to drop the prefix.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I think we should do this.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I agree!

Comment 3

[Matthew Schranz [:mjschranz]]

Attachment: Proposed patch removing moz prefix

I imagine I might need to fix some of the current tests for this too, but I wanted to make sure the changes in the code were correct first before doing so.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 596057 [details] [diff] [review]
Proposed patch removing moz prefix

Review of attachment 596057 [details] [diff] [review]:
-----------------------------------------------------------------

You need to update tests too. r=me once you do.

::: content/base/public/nsIDOMFile.idl
@@ +59,5 @@
>  interface nsIURI;
>  interface nsIPrincipal;
>  interface nsIDOMBlob;
>  
> +[scriptable, builtinclass, uuid(6640c2aa-fac0-497f-ba0f-60506f9a489f)]

This change doesn't affect the binary signature, so no need to rev the IID.

Comment 5

[Matthew Schranz [:mjschranz]]

Attachment: Proposed patch removing moz prefix

Should cover it.

Comment 6

[Matthew Schranz [:mjschranz]]

You know, might have used the wrong command there when renaming the file. Let me know if that causes an issue.

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Yeah, we'd prefer to keep the history. If you use "hg mv oldname newname" that should produce a better diff.

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

And it'll make reviewing easier :)

Comment 9

[Matthew Schranz [:mjschranz]]

Attachment: Proposed patch removing moz prefix

Simply forgot a flag I need when generating patches with git!

Comment 11

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/1f99e7a087c1

Comment 12

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/23a142cb2fc1

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/23a142cb2fc1

Comment 14

[Ed Morley [:emorley]]

and https://hg.mozilla.org/mozilla-central/rev/1f99e7a087c1

Comment 15

[Daniel Desira]

Do you need verification that the bug is fixed? I am more than willing to do it.

Comment 16

[Eric Shepherd [:sheppy]]

Docs updated:

https://developer.mozilla.org/en/DOM/Blob

Added to Firefox 13 for developers.