725304 - Move Comments SQL query to a middleware service

Status: RESOLVED FIXED

(Socorro Graveyard :: Middleware, defect)

Description

[[DEACTIVATED] Adrian Gaudebert]

The SQL query for comments in webapp-php/application/models/common.php needs to be moved to an independent middleware service.

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

Opened pull request: https://github.com/mozilla/socorro/pull/348

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/5148e1a99d2d7eacb358e3498962d3098f3383b7
Merge pull request #348 from AdrianGaudebert/725304-comments-middleware-service

Fixes bug 725304 - Created a new middleware service for comments.

Comment 3

[[DEACTIVATED] Adrian Gaudebert]

Steps to QA
-----------

1. Go to advanced search and run any query during a week before now.
2. Click on a signature with enough crash reports to make sure it has comments.
3. On report/list, verify that the number of comments is correct (compare with prod and / or with comments listed in the Reports tab). 

4. Click a comment's date to go to report/index and verify that you have comments in the Comments tab. That tab is supposed to see comments related to the crash signature for the last 7 days, if you're first search wasn't for a week before now you may not see that comment.

Comment 4

[Austin Davis [:austind]]

Reopening: I may be misunderstanding the steps to test in comment 3 however here is what I am seeing. I am getting a different number of comments on prod than in stage for the same query.

Returns a result of 100 comments:
https://crash-stats.allizom.org/report/list?product=Thunderbird&query_search=signature&query_type=contains&reason_type=contains&date=02%2F10%2F2012%2022%3A46%3A56&range_value=1&range_unit=weeks&hang_type=any&process_type=any&do_query=1&signature=JSObject%3A%3AgetGlobal%28%29

Returns a result of 239 comments:
https://crash-stats.mozilla.com/report/list?product=Thunderbird&query_search=signature&query_type=contains&reason_type=contains&date=02%2F10%2F2012%2022%3A46%3A56&range_value=1&range_unit=weeks&hang_type=any&process_type=any&do_query=1&signature=JSObject%3A%3AgetGlobal%28%29

Comment 5

[[DEACTIVATED] Adrian Gaudebert]

Oh, good catch. By default the number of results sent back by the middleware service is 100. Which means with this new system there can never be more than 100 comments... I was thinking this would be a very unusual thing, but I may have been underestimating the number of comments our users give us! 

Will fix that next Monday to make the maximum number of comments infinite.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/0696ac4c9542e54e13e53a9992a599c7d630ad89
Merge pull request #374 from AdrianGaudebert/725304-comments-middleware-service

Fixes bug 725304 - Allowed infinite number of results instead of max 100.

Comment 7

[Matt Brandt [:mbrandt]]

Excellent find :austind (comment 4)! lgtm on dev.

Comment 8

[Matt Brandt [:mbrandt]]

QA verified on stage.

Comment 9

[[github robot]]

Commit pushed to stage at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/6b298870b9899cb65314c8ea4aaf26024438a9a1
Fixes bug 725304 - Allowed infinite number of results instead of max 100.