725310 - Validation should not issue warnings about the use of globals in restartless add-ons

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Description

[Dimitri Saltanov]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:10.0) Gecko/20100101 Firefox/10.0
Build ID: 20120129021758

Steps to reproduce:

Currently each modification and some accesses to JS globals generate warnings for restartless add-ons. But since those globals reside in the add-ons own isolated sandboxes any modifications are most unlikely to spill into common spaces (unless an overwrite is directly requested or part of specially injected code), which limits their liability to add-on's performance. This is a minor annoyance by itself but the amount of such superfluous warnings can be confusingly enormous.

Comment 1

[Wil Clouser [:clouserw]]

Are you referring to Jetpack SDK based add-ons?

Comment 2

[Dimitri Saltanov]

(In reply to Wil Clouser [:clouserw] from comment #1)
> Are you referring to Jetpack SDK based add-ons?

Since they are restartless they can be affected too, but I'm referring to the phenomenon in general.

Comment 3

[Matt Basta [:basta]]

Fixed:

https://github.com/mozilla/amo-validator/commit/bb3b924b330dd09a2d45905ec198005487dd0461