CrashReporter can call doFinish twice

RESOLVED FIXED in Firefox 13

Status

()

Firefox for Android
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mfinkle, Assigned: mfinkle)

Tracking

unspecified
Firefox 13
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 595433 [details] [diff] [review]
patch

Followup from bug 723495

We should be returning if the spec is null here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/CrashReporter.java.in#245

Without that we could call doFinish() twice, since the try block will silence the exception and call the doFinish() at the bottom of the function.

This patch adds the return and ports the changes to the XUL version too.
Attachment #595433 - Flags: review?(bugmail.mozilla)
Attachment #595433 - Flags: review?(bugmail.mozilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/50cc461ad671
Backed out of inbound for xul build failure:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=ee360a77bfc9

https://hg.mozilla.org/integration/mozilla-inbound/rev/06f65b4e6c81
Assignee: nobody → mark.finkle
relanded with a XUL fix:
https://hg.mozilla.org/integration/mozilla-inbound/rev/538479680915
https://hg.mozilla.org/mozilla-central/rev/538479680915
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Comment on attachment 595433 [details] [diff] [review]
patch

[Approval Request Comment]
Fixes a crash
Attachment #595433 - Flags: approval-mozilla-beta?
Attachment #595433 - Flags: approval-mozilla-aurora?

Comment 6

6 years ago
Comment on attachment 595433 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.
Attachment #595433 - Flags: approval-mozilla-beta?
Attachment #595433 - Flags: approval-mozilla-beta+
Attachment #595433 - Flags: approval-mozilla-aurora?
Attachment #595433 - Flags: approval-mozilla-aurora+
Comment on attachment 595433 [details] [diff] [review]
patch

Clearing approval for Aurora 12 and Beta 11 because we are not currently planning a Native Fennec release of these versions.  If this changes in the future, we will likely do a mass uplift of all native fennec changes.  For now, let's get these bugs off the channel triage radar.

[Filter on the string "mbrubeck-bugspam" if you want to delete all of these emails at once.]
Attachment #595433 - Flags: approval-mozilla-beta+
Attachment #595433 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.