Please set DEBUG to false on dev/staging

VERIFIED FIXED

Status

--
major
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: stephend, Assigned: jd)

Tracking

0.1 - Solkar

Details

(URL)

(Reporter)

Description

7 years ago
Please disable DEBUG on -dev, so we can test custom error pages:

http://reps-dev.allizom.org/fdsjkl
(Reporter)

Updated

7 years ago
Blocks: 722518
Group: mozilla-reps
I just committed a patch, currently waiting for code review, that:

1. provides a 404 page
2. provides two urls, enabled only in debug mode, /404 and /500 so you can test 404 and 500 errors with unsetting DEBUG mode.


Link to pull request:
https://github.com/mozilla/remo/pull/10
Assignee: nobody → giorgos
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 2

7 years ago
This works with /500 and /404, as noted in comment 1, but why are we leaving DEBUG to true on dev?
(Reporter)

Comment 3

7 years ago
Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Stephen,

I suggest that we only set Debug=False to stage, as dev returns helpful messages for development. Is there a specific reason you want them both to the same state?

Thanks
(Reporter)

Comment 5

7 years ago
(In reply to Giorgos Logiotatidis [:giorgos] from comment #4)
> Stephen,
> 
> I suggest that we only set Debug=False to stage, as dev returns helpful
> messages for development. Is there a specific reason you want them both to
> the same state?
> 
> Thanks

We like to test "as commits come in," (allows for much-quicker turnaround) which doesn't happen on stage (which, IIRC, still requires a specific push by IT).  Typically, developers have their own development environments, and -dev is used for trunk/master testing.  There are cases, too, where we're testing a hotfix or new feature from a branch, and it'd be best if -dev were the same environment, setup-wise, as stage and prod, if at all possible.

Additionally, in the case of database errors, many times crucial login/DB-name/path info will be leaked, because of DEBUG=true (ask InfraSec).
OK Agreed. I 'll use other means of error reporting.
Jason,

Can you please:

1. Set DEBUG=False to dev server
2. Set DEBUG=False and DEV=False to stage server and redirect all HTTP traffic to HTTPS to have a perfect clone of our production server.

Thanks!
Assignee: giorgos → jcrowe
(Assignee)

Comment 8

7 years ago
Giorgos,

This has been completed.

Regards
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 9

7 years ago
Verified FIXED; thanks!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.