725417 - Please set DEBUG to false on dev/staging

Status: VERIFIED FIXED

(Mozilla Reps Graveyard :: reps.mozilla.org, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Please disable DEBUG on -dev, so we can test custom error pages:

http://reps-dev.allizom.org/fdsjkl

Comment 1

[Giorgos Logiotatidis [:giorgos]]

I just committed a patch, currently waiting for code review, that:

1. provides a 404 page
2. provides two urls, enabled only in debug mode, /404 and /500 so you can test 404 and 500 errors with unsetting DEBUG mode.


Link to pull request:
https://github.com/mozilla/remo/pull/10

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

This works with /500 and /404, as noted in comment 1, but why are we leaving DEBUG to true on dev?

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Reopening.

Comment 4

[Giorgos Logiotatidis [:giorgos]]

Stephen,

I suggest that we only set Debug=False to stage, as dev returns helpful messages for development. Is there a specific reason you want them both to the same state?

Thanks

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Giorgos Logiotatidis [:giorgos] from comment #4)
> Stephen,
> 
> I suggest that we only set Debug=False to stage, as dev returns helpful
> messages for development. Is there a specific reason you want them both to
> the same state?
> 
> Thanks

We like to test "as commits come in," (allows for much-quicker turnaround) which doesn't happen on stage (which, IIRC, still requires a specific push by IT).  Typically, developers have their own development environments, and -dev is used for trunk/master testing.  There are cases, too, where we're testing a hotfix or new feature from a branch, and it'd be best if -dev were the same environment, setup-wise, as stage and prod, if at all possible.

Additionally, in the case of database errors, many times crucial login/DB-name/path info will be leaked, because of DEBUG=true (ask InfraSec).

Comment 6

[Giorgos Logiotatidis [:giorgos]]

OK Agreed. I 'll use other means of error reporting.

Comment 7

[Giorgos Logiotatidis [:giorgos]]

Jason,

Can you please:

1. Set DEBUG=False to dev server
2. Set DEBUG=False and DEV=False to stage server and redirect all HTTP traffic to HTTPS to have a perfect clone of our production server.

Thanks!

Comment 8

[Jason Crowe [:jd]]

Giorgos,

This has been completed.

Regards

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; thanks!