This blocks some SS tests like unpack-code.
Chris, you have a patch for this, right?
NAME and CALLNAME should be identical now.
(In reply to Brian Hackett (:bhackett) from comment #1)
> NAME and CALLNAME should be identical now.
Yeah I should have mentioned this in comment 0, but Chris was investigating a crash with the one-liner to compile CALLNAME. Probably a pre-existing NAME bug, I don't know.
Created attachment 597779 [details] [diff] [review]
Calling NestingPrologue when bailing out fixes the test failures. I don't really know how this works though, so let me know if you want me to call this function somewhere else.
Comment on attachment 597779 [details] [diff] [review]
The nesting prologue should not be called directly, and should only be called in the prologue of function frames (e.g. fp->functionPrologue()). Since IM doesn't run the prologue at function frame entry, the nesting state should probably be completely disabled, test for ion being enabled near the cx->typeInferenceEnabled() test in TypeScript::SetScope. This will not be correct though once ion config options can be dynamically changed.
Created attachment 598179 [details] [diff] [review]
Disables the nesting state in TypeScript::SetScope. Eventually we will want to add the same optimization to IM, right?
Comment on attachment 598179 [details] [diff] [review]
Yeah. The nesting prologue stuff can be done hand in hand with maintaining call object state.