725681 - Add tests for opening Selenium IDE via the keyboard shortcut

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Selenium IDE can now be launched via a keyboard shortcut. See http://code.google.com/p/selenium/issues/detail?id=3028

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Add tests for opening Selenium IDE. v1.0

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Add tests for opening Selenium IDE. v1.1

Previous patch was missing one test.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 595804 [details] [diff] [review]
Add tests for opening Selenium IDE. v1.1

>+        browserController.keypress(null, "S", {ctrlKey: true, altKey: true});

Whenever someone adds another locale this could fail because another letter will be used. Please get the DTD and read in the correct key.

>+  sm.open(controller, {type: "shortcut"});

In the tabs module we have reverted the use of objects and use a simply string for the event type. I would propose you do the same here.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Henrik Skupin (:whimboo) [away 02/17 - 02/26] from comment #3)
> Comment on attachment 595804 [details] [diff] [review]
> Add tests for opening Selenium IDE. v1.1
> 
> >+        browserController.keypress(null, "S", {ctrlKey: true, altKey: true});
> 
> Whenever someone adds another locale this could fail because another letter
> will be used. Please get the DTD and read in the correct key.

This is not localized, and not in a DTD. It is currently in http://code.google.com/p/selenium/source/browse/trunk/ide/main/src/content/selenium-ide-overlay.xul#35

> >+  sm.open(controller, {type: "shortcut"});
> 
> In the tabs module we have reverted the use of objects and use a simply
> string for the event type. I would propose you do the same here.

Good suggestion. Updated patch coming up.

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Add tests for opening Selenium IDE. v1.2

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/394647c17e92 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/b00ea36b4fbf (mozilla-aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/3b51d4ace7bf (mozilla-beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/d39ac62eba61 (mozilla-esr10)
http://hg.mozilla.org/qa/mozmill-tests/rev/747a8f53b969 (mozilla-release)
http://hg.mozilla.org/qa/mozmill-tests/rev/361aa2aeb381 (mozilla-1.9.2)

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

This test was failing on mozilla-1.9.2 due to use of the new assertions module. We don't need it on this branch so I've backed it out: http://hg.mozilla.org/qa/mozmill-tests/rev/9ca1f8ad66e9

Comment 8

[u279076]

No noticeable regressions -- marking verified.