rename reftests/flexbox/ to reftests/box

RESOLVED FIXED in mozilla13

Status

()

Core
Layout
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
The directory /layout/reftests/flexbox/ currently contains 4 tests for -moz-box.

I'd like to rename this to reftests/box/ because:
 - it's for "display: [-vendor-]box", as compared to "display: [-vendor-]flexbox"
 - we already have 2 other directories of -moz-box related tests in "box"-themed folders:
     reftests/box-ordinal/
     reftests/box-properties/

and of course we're going to need a place to put "display: [-vendor-]flexbox" tests, and I'd like that to be in reftests/flexbox.  (In my local patches, I've been sticking them in reftests/css-flexbox, but IMHO it'd be madness to have both "flexbox" and "css-flexbox" reftest directories.)
(Assignee)

Comment 1

6 years ago
Created attachment 595812 [details] [diff] [review]
patch ("hg mv flexbox box" & update reftest.list)

Here's the patch for the rename. It's just a hg mv plus an update to reftest.list.

(I used the newer (I think?) commenting convention from that reftest.list file, with a slightly more descriptive comment than just the quoted directory name)
(Assignee)

Updated

6 years ago
Attachment #595812 - Flags: review?(dbaron)
(Assignee)

Updated

6 years ago
Blocks: 666041
Comment on attachment 595812 [details] [diff] [review]
patch ("hg mv flexbox box" & update reftest.list)

r=dbaron
Attachment #595812 - Flags: review?(dbaron) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6711ced03ad3
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/6711ced03ad3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.