725756 - Flickering when creating new tab or closing last (and only) one [again]

Status: REOPENED

(Firefox :: New Tab Page, defect, P3)

Description

[Marat Tanalin]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20100101 Firefox/11.0
Build ID: 20120201153158

Steps to reproduce:

The bug 543306 has now appeared _again_ in Firefox 13 now that visited-pages' thumbnails are displayed in empty tabs.

New bug is filed as recommended by Dão Gottwald in bug 543306 comment 7.


Actual results:

When closing last (and only) opened tab, empty page is closed and then new one is created. This results in flickering both background and thumbnails (gray background appears briefly, thumbnails disappear and then appear again).

As previously (when current bug and bug 408929 have been initially reported), same applies to creating new tab.

Flickering takes place when creating _each_ new tab (even if we are on _non-empty_ tab):

gray background appears, and _then_ this empty gray content area is _replaced_ with white background with thumbnails.

So we apparently have wrong chain:
"current page -> gray background -> white background and thumbnails".

while expected (correct) chain is different:
"current page -> white background and thumbnails"
(without "gray background" step).


Expected results:

There should not be flickering.

* _Event_ of closing last empty tab should be _ignored_ (tab should not be closed and then recreated, existing tab should just _stay open_ instead).

* When creating new tab while already having an active empty tab opened, content area should _not be re-rendered_, and _only_ new tab-label should be added to tab-bar instead.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Will be fixed by bug 753448.

Comment 2

[Marat Tanalin]

Apparently this bug is _not_ fixed by bug 753448.

Tested with Firefox/17.0 ID:20120819030601.

Comment 3

[Matthew N. [:MattN]]

Mass-move to Firefox::New Tab Page.

Filter on new-tab-page-component.

Comment 4

[roxleitan]

20160502172042 Mozilla/5.0 (Windows NT 6.1; rv:46.0) Gecko/20100101 Firefox/46.0
20160601061753 Mozilla/5.0 (Windows NT 6.1; rv:49.0) Gecko/20100101 Firefox/49.0

I have tested your issue on latest FF release 46.0 and latest Nightly build and could not reproduce it. 
Is this still reproducible on your end ? If yes, can you please retest this using latest FF release and latest Nightly build (https://nightly.mozilla.org/) and report back the results ? When doing this, please use a new clean Firefox profile, maybe even safe mode, to eliminate custom settings as a possible cause (https://goo.gl/PNe90E).

Comment 5

[Marat Tanalin]

Looks like, in nonprivate windows, background is now not flickering, but thumbnails are still flickering.

Also, latest Aurora (Dev. Edition) versions have a new dark/purple style of private windows (Fwiw, I've even been forced to override it back via a user stylesheet since it's VERY uncomfortable for eyes), and background in private windows is flickering too — this is even worse given that the contrast between the flashy light background and the dark (purple) private background is much higher than in nonprivate mode.

Comment 6

[Jessilyn Davis]

Hello!

This bug has been closed due to inactivity and/or the potential for this bug to no longer be an issue with the new Discovery Stream-powered New Tab experience.

Please help us triage by reopening if this issue still persists and should be addressed.

Thanks!

Comment 7

[Marat Tanalin]

The bug is still here. Tested with the latest Firefox Developer 71.0b5 (20191028110005) and Firefox Nightly 72.0a1 (20191029093803).

Comment 8

[Jessilyn Davis]

Thank you for verifying, Marat! We've got this back on our radar.