Closed Bug 725833 Opened 12 years ago Closed 12 years ago

Adjust URLs for new reviewer workflow

Categories

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: clouserw, Unassigned)

References

Details

Editor tools.  Bam:

  https://addons-dev.allizom.org/en-US/editors/

The new age of peace and prosperity at AMO has the editors folks referred to as "reviewers."  To accommodate that we should adjust the URLs and page headers to say "Reviewer Tools" etc.  Don't get carried away searching, we'll find them eventually.  The new plan also speaks of separate areas for each of the types we review.  Thanks to reverse() this should be relatively easy.  A rough plan:

/editors/ becomes /reviewers/addons/
/editors/queue/(fast|nominated|pending|preliminary) becomes /reviewers/addons/queue/$name
/editors/queue/reviews becomes /reviewers/(apps|addons|\$personas)/queue/reviews  (this has the same content at 3 different URLs.  We could make 1 URL without the app/addon/persona stuff if you like that better)
/editors/queue/apps becomes /reviewers/apps/queue/full
/editors/performance becomes /reviewers/addons/performance
/editors/motd becomes /revewiers/addons/motd

We should make a new /reviewers/ top level page that can just 302 to /reviewers/addons/ for now.

Basically we're just putting all the current content (save apps) under an /addons/ namespace to make room for apps and $personas to take up their spots.
we could drop the /queue/ unless anyone has any special attachments to it.
i.e.  /reviewers/addons/fast - currently /editors/queue/ just redirects to /editors/queue/pending anyway afaik and with apps and personas the extra /queue/ is even more redundant.

I agree that /reviewers/(apps|addons|\$personas)/queue/reviews would be simpler as 1 URL - can it be 'moderated' rather than 'reviews' though?  ('Review' is used in a few different contexts). So  just /reviewers/moderated/ ?
Its not clear from the proposal what happens to the editors/review/$slug url but assuming they end up being reviewers/(addons|apps|$personas)/review/$slug, can we have a redirect to the correct place?

So, reviewers/review/$slug redirects to reviewers/addons/review/$slug if $slug is of type addon, etc. - separate bug?
(In reply to Andrew Williamson [:eviljeff] from comment #1)
> we could drop the /queue/ unless anyone has any special attachments to it.

Agree.

> I agree that /reviewers/(apps|addons|\$personas)/queue/reviews would be
> simpler as 1 URL - can it be 'moderated' rather than 'reviews' though? 
> ('Review' is used in a few different contexts). So  just
> /reviewers/moderated/ ?

Agree.

(In reply to Andrew Williamson [:eviljeff] from comment #2)
> So, reviewers/review/$slug redirects to reviewers/addons/review/$slug if
> $slug is of type addon, etc. - separate bug?

This all depends on whether slugs are unique across add-ons, apps an personas, or if they're just unique within their own sets. I would suspect the latter, given how apps and personas would quickly exhaust all possible names...
This has been implemented on Marketplace now, similarly to the proposal in comment 0 so closing the AMO bug for it.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.