725858 - Don't load sqlite for profile migration unless we're actually migrating a profile

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

I'm seeing the setup screen appear in Fennec, even though I have no previous profile on my device. There's two places I see us doing work we don't need. First, my brilliant GeckoDirProvider is creating a profile for us, even if we don't have or need one, which means we always think we have a profile.

Secondly, I'm seeing a lot of time spent in ensureSqliteLibsLoaded even though we aren't doing a migration. We'll do this on every startup, so we should delay and only do it if we know there's a data to migrate.

Patch for the second coming. I avoided offering the first option earlier because its a little tricky I think...

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

This cuts the migration time from 500-100ms to around 3ms for me (to be fair I only saw 500 once). I assume we're hitting it every time, which is why I constantly see the startup splash fly by for a second I assume.

Comment 2

[Wesley Johnston (:wesj)]

Dang it wrong patch. One sec...

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch

I moved these timers outside the getProfileDir loop so that we could also include it in our measured time here (although its very small for me...).

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/83e4a240abc0

Comment 5

[Wesley Johnston (:wesj)]

backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/d83905d0154b
reland: https://hg.mozilla.org/integration/mozilla-inbound/rev/6b12265a4aa0

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6b12265a4aa0