PathExtentsToMaxStrokeExtents needs to take a transform argument

RESOLVED FIXED in mozilla13

Status

()

Core
SVG
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla13
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
PathExtentsToMaxStrokeExtents currently just uses GetCanvasTM() to figure out how much to expand the stroke by. When calling GetBBoxContribution, this can mean that we get the expansion very wrong, since the transform to the canvas is not usually what we want.

The kill-covered-regions patches in bug 614732 switch to using GetBBoxContribution in user space (instead of canvas space) as part of figuring out the covered region, and some tests fail as a result of PathExtentsToMaxStrokeExtents using the canvas TM.
(Assignee)

Comment 1

5 years ago
Created attachment 595925 [details] [diff] [review]
patch

This patch also depends on the changes to test_bounds.html in bug 725897.
Attachment #595925 - Flags: review?(roc)
(Assignee)

Comment 2

5 years ago
Passed Try.
(Assignee)

Updated

5 years ago
Attachment #595925 - Flags: review?(roc) → review?(longsonr)

Updated

5 years ago
Attachment #595925 - Flags: review?(longsonr) → review+

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/6d5192687c91
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.