runtests.py does not handle media that requires multiple abc files during AOT compilation

RESOLVED FIXED in Q2 12 - Cyril

Status

Tamarin
Tools
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Brent Baker, Assigned: Brent Baker)

Tracking

(Blocks: 1 bug)

unspecified
Q2 12 - Cyril
x86
Mac OS X

Details

Attachments

(3 attachments)

(Assignee)

Description

6 years ago
If a testcase requires multiple abc files to be passed to the shell at runtime it is specified in the <testname>.as.avm_args file. This file is currently NOT checked during AOT compilation, so any media that requires additional abc files are runtime will not properly compile for AOT.

Could add code in compile_aot() to lookup and parse <testname>.as.avm_args to see if additional abc files should be passed to adt.
(Assignee)

Comment 1

6 years ago
Created attachment 597815 [details] [diff] [review]
abcasm patch

May sure to copy the extra abc files need for AOT compilation into the output directory. The extra abcs need to be uniquely named based on the root abc file.

This also contains a little drive-by cleanup to make sure that we are calling close() on the files that we open.

Comment 2

6 years ago
changeset: 7209:09a8fe762eaa
user:      Brent Baker <brbaker@adobe.com>
summary:   Bug 726023: May sure to copy the extra abc files need for AOT compilation into the output directory. The extra abcs need to be uniquely named based on the root abc file.

http://hg.mozilla.org/tamarin-redux/rev/09a8fe762eaa

Comment 3

6 years ago
Only works for abcasm at the moment.  mops tests are failing due to lack of multi-abc support as well.
Assignee: nobody → brbaker
Target Milestone: --- → Q2 12 - Cyril
(Assignee)

Comment 4

6 years ago
Created attachment 603723 [details] [diff] [review]
Find additional abc files via avm_args file and the multiabc marker
Attachment #603723 - Flags: review?(dschaffe)

Comment 5

6 years ago
changeset: 7261:e5922813db63
user:      Brent Baker <brbaker@adobe.com>
summary:   Bug 726023: Find additional required runtime abc files via avm_args file and the multiabc marker. This is necessary when compiling with AOT since the runtime abcs must be linked at compilation time

http://hg.mozilla.org/tamarin-redux/rev/e5922813db63

Updated

6 years ago
Attachment #603723 - Flags: review?(dschaffe) → review+
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

6 years ago
Created attachment 604056 [details] [diff] [review]
make sure that the abc files have been written

Comment 7

6 years ago
changeset: 7267:c1cdcc34d960
user:      Brent Baker <brbaker@adobe.com>
summary:   Bug 726023: make sure that file copying is complete before calling adt

http://hg.mozilla.org/tamarin-redux/rev/c1cdcc34d960

Comment 8

6 years ago
changeset: 7332:6549d845694c
user:      Brent Baker <brbaker@adobe.com>
summary:   Bug 726023: AOT compilation will sometimes fail when additional abc files are not copied over to the output directory prior to linking. This attempts to make sure that necessary files are copied over, see comment in copyfile_retry() for more info (r=trbaker)

http://hg.mozilla.org/tamarin-redux/rev/6549d845694c
You need to log in before you can comment on or make changes to this bug.