726057 - Validator warnings missing for .so files on viewer/compare page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P2)

Description

[Andrew Williamson [:eviljeff]]

Attachment: screenshot of the issue

files with binary like extensions, such as .dll .dylib .exe .so are flagged by the validator:

https://addons.mozilla.org/en-US/developers/addon/gipsy-flight-manager/file/143459/validation

but in the viewer the warnings for .so files aren't displayed.

to quote Kris:
"Looks like some middleware is trying to linkfy *.so even in the JSON transmitted by the validator.
File path comes through as: platform/Linux_x86_64-gcc3/components/<a href="http://outgoing.mozilla.org/v1/0d444c619fc0ab7df2eba62e790b487e00b8d23c/http%3A//gipsy.so" rel="nofollow">gipsy.so</a>"

Comment 1

[Kris Maglione [:kmag]]

This is still happening. Middleware shouldn't be mangling JSON responses like this.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

Cvan, is there something that can be done about the *.so linkification?

Comment 3

[Kris Maglione [:kmag]]

Urgh.

    if data['validation']:
        data['validation'] = limit_validation_results(escape_validation(
            data['validation']))
...
    return escape_all(validation)
...
    if isinstance(v, basestring):
        v = jinja2.escape(smart_unicode(v))
        v = linkify_with_outgoing(v)
        return v
...

Comment 4

[Mark Striemer [:mstriemer]]

If it helps any I recently added a `linkify` param to escape all on zamboni as it was causing a similar issue on the full consumer facing validation results page.

https://github.com/mozilla/zamboni/blob/master/apps/amo/utils.py#L717-L732
https://github.com/mozilla/zamboni/commit/3fbe5962a4edf90860f118c12646f14ef549fe3f

Comment 5

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/olympia/pull/326

Comment 6

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/5434d59debb9b864a25ac3f7776fa1c49582046a

STR:
1/ upload an addon that has compiled files (like the one from this bug)
2/ check the full validation results during the submission of the addon, and validate that the .so files aren't linkified, but that normal links (full links, with scheme and all, like https://....) are correctly linkified
3/ one the addon is submitted, validate that the .so files are correctly tagged in the file viewer

Comment 7

[Victor Carciu]

Verified as fixed. The .so files are not linkified and correctly tagged in file viewer : http://screencast.com/t/s8umGPeTDq