726078 - bad error message/signature on corrupt crashing thread stack

Status: RESOLVED FIXED

(Socorro :: Backend, task)

Description

[Laura Thomson :laura]

https://crash-stats.mozilla.com/report/index/c183a42c-6cdb-408a-a6ea-8f9f12120210

If you look at the raw dump, the crashing thread is:
5|0|||||0x4246c83

yet the processor says:
Signature 	EMPTY: no crashing thread identified 

And in the processor notes:
Processor Notes 	CSignatureTool: No signature could be created because we do not know which thread crashed

As an aside, this crash is now known to be caused by this 
https://addons.mozilla.org/en-us/firefox/addon/music-player-minion/

Comment 1

[K Lars Lohn [:lars] [:klohn]]

Attachment: tarball contain a crash that demonstrates the problem is fixed

Comment 2

[K Lars Lohn [:lars] [:klohn]]

The CSignatureTool created a bad signature and error message when the stack frame was bad. This happended because the crashed thread number wasn't being passed to the signature generation tool. The crashed thread number is only used in this context to choose between error messages and create a default signature. Other non-degenerate stack frames didn't suffer the problem of not having the crashing thread number because they didn't have to create an error message.

the attached crash demonstrates the fix.  Submitting it should result in the signature being:
"@0x4246c83" and the string "CSignatureTool: No proper signature could be created because no good data for the crashing thread (5) was found" being in the processor notes.

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Mobile Corrupt stacks?  I think this is the same issue?  If not please let me know and I will create a new bug or place in the appropriate bug.

https://crash-stats.mozilla.com/report/list?range_value=7&range_unit=days&date=2012-02-14&signature=EMPTY%3A%20no%20crashing%20thread%20identified%3B%20corrupt%20dump&version=FennecAndroid%3A13.0a1

Comment 4

[K Lars Lohn [:lars] [:klohn]]

@nhirata: your crashes represent a totally different issue.  This bug is about Socorro Processor choosing the wrong error message when given a certain flavor of corrupted dump.  

Looking through the crashes in your example, you've got a Breakpad problem.  The dump file provided to Socorro is completely empty.  Socorro can't do anything with it, so it reports an  errors in the ProcessorNotes and then chooses an appropriate "corrupt" signature.

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Ok, thanks.  Going to report a new bug.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/16bcd7924bd0956ca38ef3eab896a1423456ec7f
Merge pull request #338 from twobraids/no-thread-bug726078

fixes Bug 726078 - bad error message/signature on corrupt crashing thread stack