726127 - update elastic search index with question.num_votes_past_week

Status: VERIFIED FIXED

(support.mozilla.org :: Search, defect, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

We have a cron job that recalculates questions.num_votes_per_week, but does it directly in the database. Because it's done directly in the database, it doesn't trigger the post_save signal and thus the numbers aren't updated in the elastic search index.

We need to fix this---otherwise that number gets stale.

Possibilities:

1. add to the cronjob some code that also updates the database

2. write another cronjob that updates questions.num_votes_per_week in the index from the database

3. some third thing


Making this a P1 since this should block an ES rollout.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Putting this in the 2012.4 sprint as a 2pter. Pretty sure it should be a 2pter.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this one.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

It's "num_votes_past_week" and not "num_votes_per_week". Oops.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

https://github.com/mozilla/kitsune/pull/502

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master in https://github.com/mozilla/kitsune/commit/f4ccd5ed956f8c1bb2b44beab976701e793b20fa

Assuming this cronjob is running on -dev/-stage, to QA:

1. find a support question (or create one) that has no "i have this problem too" votes in the last week. e.g. the text should read "0 new this week"

2. search for that question using the "support question" tab in advanced search.

It should show up in search results.

Search for it again in "support question" tab in advanced search making sure to specify that "votes more than 0".

The question should not show up in the results.

Thus you now have a question where if you search by Votes > 0, it doesn't show up, so if we change that number, then it should show up.

3. vote on the question by clicking on the "I have this problem too" button.

Wait for the cronjob to kick off--in production I think it happens at 1:40 am, though I don't know what timezone that is.

4. If you check the page question is on, it should reflect that it now has a question vote. It'll say something like "1 new this week" next to the "I have this question too" button.

5. Now search for that question using the "support question" tab in advanced search making sure to specify that "votes more than 0"

It should show your question in the results now.

Comment 6

[Rebecca Billings [:rbillings]]

I created a question and voted on it: https://support.allizom.org/en-US/questions/778593
I see that 3 new people this week have this question
Searching in advanced search, under Support Questions for 'frosting' gives me results- but if I change it to show More than 1, zero results display

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

When I do an advanced search under support questions for 'frosting' with votes more than 0, I see it, but when I do votes more than 1, I don't.

Maybe you got some of the votes in before the cron job kicked off and some after? Maybe wait another 24 hours for the cron job to run again and try it then?

Comment 8

[Rebecca Billings [:rbillings]]

Verified. All of my searches are now giving results- I guess it was a matter waiting for the cron job to run again.