726132 - Adding toolbarseparator to tabs toolbar increases height of tabs

Status: RESOLVED INVALID

(Firefox :: Theme, defect)

Description

[Jorge R]

Attachment: Separator_what_happens.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:13.0a1) Gecko/20120210 Firefox/13.0a1
Build ID: 20120210040207

Steps to reproduce:

When you drag a separator to tabs toolbar, tabs became broken in the bottom.

Tried in new profile and it happens too.

Comment 1

[Simona Badau, Desktop QA]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:13.0a1) Gecko/20120208 Firefox/13.0a1

I can confirm this on the latest Nightly. Issue is visible with the Default theme enabled.
Setting status of this bug to NEW.

Comment 2

[Stefan [:stefanh]]

OK, so bug 583510 added a min-height of 22px to the separators. This was to overcome the fact that toolbarseparators had a height of 0 (caused by setting -moz-box-align to the toolbars).

So, since the toolbarseparator in this case has a height of 22px it will vertically stretch the tabs toolbar. It appears that the same thing happens when adding a toolbarseparator to the personal toolbar (toolbar increases in height).

Now, the tabs toolbar have "-moz-box-align: stretch", so setting the toolbarseparator's min-height to 0 (if the separator is in the tabs toolbar) would fix this bug. But we'd still have the issue with the personal toolbar.

Markus (mstange): do you think it would be OK to revert to -moz-box-align: stretch for all toolbars except for the #nav-bar? We could differentiate the height of toolbarseparators depending on what toolbar they are in, but...

Comment 3

[Stefan [:stefanh]]

JFTR, the -moz-box-align change is bug 559033.

Comment 4

[Stefan [:stefanh]]

Actually, it's the tabs element that increases in height.

Comment 5

[Stefan [:stefanh]]

Markus, another question: do you remember the reason for adding '-moz-box-align: center' to the personal toolbar (bug 546874)?

Comment 6

[Stefan [:stefanh]]

Attachment: Revert to 'stretch', except for the #nav-bar

Hmm, I'm I wonder if we can keep the 'center' as is, but exclude the #PersonalToolbar while keeping the css sane. That could be an alternative, if we don't want this patch.

Comment 7

[Markus Stange [:mstange]]

(In reply to Stefan [:stefanh] from comment #2)
> Markus (mstange): do you think it would be OK to revert to -moz-box-align:
> stretch for all toolbars except for the #nav-bar?

Probably. According to bug 559033 comment 11 there wasn't really a reason to set it on other toolbars, except for consistency.

(In reply to Stefan [:stefanh] from comment #5)
> Markus, another question: do you remember the reason for adding
> '-moz-box-align: center' to the personal toolbar (bug 546874)?

I don't know if it necessarily needs to be applied to the toolbar, but it needs to be ensured that bookmarks buttons aren't stretched vertically even if bigger buttons are placed in the bookmarks toolbar. But bookmarks buttons have some wrapper elements around them anyway, so align:center can probably be set on of those wrappers.

In general, -moz-box-align: stretch expresses that the controls in the toolbar don't determine their own height, but depend on each other for their height. But that's not the case in toolbars; the separator is an unfortunate exception.

How many pixels is the separator to high in the toolbars? Can we just decrease its height?

Comment 9

[Daniele Orlando]

Any news. This bug is still present in FF 12. Come on!

Comment 10

[:Gijs (he/him)]

We no longer support toolbar separators in Firefox.