to be faster and cleaner, rewrite messengerdnd.js to use two flavors (one for message, one for folder)

VERIFIED FIXED in Future

Status

SeaMonkey
MailNews: Message Display
P4
normal
VERIFIED FIXED
18 years ago
14 years ago

People

(Reporter: (not reading, please use seth@sspitzer.org instead), Assigned: Navin Gupta)

Tracking

(Blocks: 1 bug)

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

according to pink:

"I've fixed some bugs in isDataFlavorSupported on mac within the last 
month or two. Try again."
(Assignee)

Comment 1

18 years ago
If you want you can try out ver 1.21, that was written using two flavors. 
we can't go back to a previous version of messengerdnd.js, because of the new
outliner widget.

setting milestone and priority.  this is low priority since dnd works.
Status: NEW → ASSIGNED
Priority: -- → P4
Target Milestone: --- → Future
(Assignee)

Comment 3

16 years ago
Let me see if I can fix this to use two flavors. I need for another drag and
drop bug. 
Assignee: sspitzer → naving
Blocks: 155643
Status: ASSIGNED → NEW
(Assignee)

Comment 4

16 years ago
Created attachment 92051 [details] [diff] [review]
proposed fix

Made it so that we use two new flavors, separate for message
(text/x-moz-message) and folder (text/x-moz-folder). 

tested works on mac and win32.
(Assignee)

Comment 5

16 years ago
Bhuvan, David, Can I get reviews ? thx. This was needed for that standalone drag
and drop bug. 
Status: NEW → ASSIGNED

Comment 6

16 years ago
Comment on attachment 92051 [details] [diff] [review]
proposed fix

sr=bienvenu, if you remove the dump

+	 dump ("dataFlavor "+ dataFlavor.value + "\n");
Attachment #92051 - Flags: superreview+

Updated

16 years ago
Attachment #92051 - Flags: review+

Comment 7

16 years ago
Comment on attachment 92051 [details] [diff] [review]
proposed fix

-    var dropMessage = true; 
and looks like this not declared/initialized anywhere. That may result in 
warnings, etc. Fix as needed. No need for a new patch. 

r=bhuvan
(Assignee)

Comment 8

16 years ago
fixed on trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
QA Contact: esther → stephend
Hardware: PC → All
Verified FIXED
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.