726281 - In-Reply-To: and References: should be removed from mail saved as Template

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[WADA:World Anti-bad-Duping Agency]

In-Reply-To: and References: should be removed from mail saved as Template.

(1) "Edit As New" of an existent mail which has In-Reply-To: and References:.
(2) Save As Template, Exit composition window.
    => In-Reply-To: and References: of original mail is kept in template mail.
(3) Double click of the saved template mail (==Edit As New),
    modify mail, Send Later.
    => In-Reply-To: and References: of original mail still exists
       in mail which will be sent.

If "Edit As New" + "Save As Draft", above is correct action, because purpose is modified version of previous reply mail when the existent mail is reply mail.
However, I believe use case and user's expectation of "Edit As New" + "Save As Template" is never creation of template of reply mail which is same reply as the existent mail.
User's purpose of "Edit As New" + "Save As Template" is re-use of mail data such as To:, CC:, part of message text of the mail which he sent or received, with minimum modification.

Comment 1

[Magnus Melin [:mkmelin]]

Shouldn't it always remove those for "edit as new"? Not only for save as draft/template.

Comment 2

[Karsten Düsterloh]

(In reply to Magnus Melin from comment #1)
> Shouldn't it always remove those for "edit as new"? 

No. "Edit As New" is meant more like "write this mail again from the same starting poing".

Comment 3

[WADA:World Anti-bad-Duping Agency]

As Karsten Düsterloh says, "Edit As New" + "Save As Draft"(needless to say +Send/Send Later too) should keep Reply-To: and References:.
This bug is for "Edit As New" on mail with In-Reply-To:/Refereces: + "Save As Template" only.

Comment 4

[Wayne Mery (:wsmwk)]

I keep getting bitten by this, so wondering if I can interest you in this :)

Comment 5

[:aceman]

Seems reasonable. I think Jorg now got practice in adding/removing email headers:)

Comment 6

[Jorg K (CEST = GMT+2)]

I'll take a look.

Comment 7

[Jorg K (CEST = GMT+2)]

Wayne: The idea is of course that you only save a *new* message as a template. As a workaround: If you create a template from a message which has unwanted headers, you'd need to save the message and remove the headers in a text editor. How often to you generate templates?

Comment 8

[Jorg K (CEST = GMT+2)]

Attachment: Proposed solution (v1a).

Is there more to it than this?

Comment 9

[Jorg K (CEST = GMT+2)]

I'll fix the trailing space, don't worry.

Comment 10

[:aceman]

Comment on attachment 8771902 [details] [diff] [review]
Proposed solution (v1a).

If we save as template, do we stay in "template-mode" so we do not need the references back? It does not look like that. Even after you save as template, you can still send out the current composition. So maybe you need to restore the .references back.

Comment 11

[Jorg K (CEST = GMT+2)]

Attachment: Proposed solution (v2a).

Now restoring references.

Maybe you won't believe me, but I was going to do this anyway. You beat me to it.

Comment 12

[Jorg K (CEST = GMT+2)]

Maybe s/oldPreferences/savedPreferences/.

Comment 13

[Wayne Mery (:wsmwk)]

(In reply to Jorg K (GMT+2, PTO during summer, NI me) from comment #7)
> How often to you generate templates?

1-2 times a month. And always from an existing email.

thanks for taking this on.

Comment 14

[:aceman]

Comment on attachment 8771917 [details] [diff] [review]
Proposed solution (v2a).

Review of attachment 8771917 [details] [diff] [review]:
-----------------------------------------------------------------

Works great. Change the variable name as you proposed. Thanks.

::: mail/components/compose/content/MsgComposeCommands.js
@@ +3086,5 @@
>    gAutoSaveKickedIn = false;
>    gEditingDraft = false;
>  
> +  let oldReferences = null;
> +  if (gMsgCompose && gMsgCompose.compFields) {

I would add a comment why we are doing this removing.

Comment 15

[Jorg K (CEST = GMT+2)]

Attachment: Proposed solution (v2b).

Changed variable name and extra comment.

Comment 16

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/bbdd29586adf

Comment 17

[Jorg K (CEST = GMT+2)]

Moved to Product Thunderbird since fix was in MsgComposeCommands.js.

rsx11m, you might be interested to port this to SM.

Comment 18

[Jorg K (CEST = GMT+2)]

Comment on attachment 8772184 [details] [diff] [review]
Proposed solution (v2b).

Let's uplift this low risk patch to Aurora since it fixes an ancient bug.

Comment 19

[rsx11m]

(In reply to Jorg K (GMT+2, PTO during summer, NI me) from comment #17)
> rsx11m, you might be interested to port this to SM.

Thanks!

Comment 20

[Jorg K (CEST = GMT+2)]

Comment on attachment 8772184 [details] [diff] [review]
Proposed solution (v2b).

[Approval Request Comment]
Regression caused by (bug #): No regression, was always wrong.
User impact if declined: Invalid references header in message based on template.
Testing completed (on c-c, etc.): Manual testing.
Risk to taking this patch (and alternatives if risky):
Low, a few lines of JS to clear and restore references before/after saving the template. Besides, that's not a common code path ;-)

Comment 21

[Jorg K (CEST = GMT+2)]

TB 49 (Aurora):
https://hg.mozilla.org/releases/comm-aurora/rev/c9d810bd10a1

Comment 22

[Kent James (:rkent)]

Comment on attachment 8772184 [details] [diff] [review]
Proposed solution (v2b).

http://hg.mozilla.org/releases/comm-esr45/rev/0b0c555b35cb

Comment 23

[Glenn Knickerbocker]

Ouch!  I just ran into this change and thought it was a bug, not a fix!  I depended on saving the In-reply-to: and References: headers in templates because I need to generate repeated replies to the same newsgroup post.  Now I have to save a draft instead, and then move it from my drafts folder to my templates folder.