Open Bug 726306 Opened 8 years ago Updated 2 years ago

Improve support for rendering drop-down buttons on Windows

Categories

(Core :: Widget: Win32, defect, P3)

x86_64
Windows 7
defect

Tracking

()

People

(Reporter: jimm, Unassigned, Mentored)

References

(Depends on 1 open bug)

Details

(Whiteboard: tpi:+)

After bug 373266 lands, we should add support for fadable drop down buttons. These buttons are tricky in that we have different rendering characteristics depending on a number of factors - 

- XUL or html
- styled or standard
- editable or read only
- ltr or rtl
- focused or not focused

Some of our current states do not produce results similar common controls. Also for rtl, we currently use DrawThemeBGRTLAware yet on vista and 7 we have part constants (CP_DROPDOWNBUTTONRIGHT/CP_DROPDOWNBUTTONLEFT) that we can use.
Feel free to remove the mentor tag if this isn't a task you would feel comfortable advising a contributor in attempting. However, we're trying to move away from the unowned list of [good first bug]s.
Whiteboard: [good first bug] → [good first bug] [mentor=jimm] [lang=c++]
Would like to work on it. I am trying to get familiar with firefox's code. But right now I am not very sure where to start for this bug. Would you please lead me to some article or pieces of code? Thank you.
well unfortunately bug 373266 hasn't landed because it has leaks on tests, and I haven't had the time to dig into it. those patches all mess with the theme code on windows that handles rendering these widgets.
Can I have this bug assigned to me please?
Is comment 3 still a concern, Jim?
Flags: needinfo?(jmathies)
Yeah, bug 373266 needs to land first. gill if you would like to resurrect those patches and sort out the leaks, feel free.
Flags: needinfo?(jmathies)
is this bug ready for development now?
Flags: needinfo?(jmathies)
(In reply to kunal bansal from comment #7)
> is this bug ready for development now?

Sure. First step would be to look into our current rendering behavior, figure out what needs to change.
No longer depends on: 373266
Flags: needinfo?(jmathies)
Mentor: jmathies
Whiteboard: [good first bug] [mentor=jimm] [lang=c++] → [good first bug] [lang=c++]
hello, is somebody working on this bug because i would like to work on this bug, i know c++ this would be my first bug so i might need some extra guidance debugging it. thanks!
(In reply to diwas joshi from comment #9)
> hello, is somebody working on this bug because i would like to work on this
> bug, i know c++ this would be my first bug so i might need some extra
> guidance debugging it. thanks!

No one is currently working this or the parent bug. 

Would you like to try finishing up bug 373266? That bug adds support for built-in widget animations, which would help us here.

If you have other changes you would like to make besides animations, feel free to detail what you would like to do so we can discuss.
Depends on: 373266
(In reply to Jim Mathies [:jimm] from comment #10)
> (In reply to diwas joshi from comment #9)
> > hello, is somebody working on this bug because i would like to work on this
> > bug, i know c++ this would be my first bug so i might need some extra
> > guidance debugging it. thanks!
> 
> No one is currently working this or the parent bug. 
> 
> Would you like to try finishing up bug 373266? That bug adds support for
> built-in widget animations, which would help us here.
> 
> If you have other changes you would like to make besides animations, feel
> free to detail what you would like to do so we can discuss.

hello, i am very new to open source and this would be my first bug, i just want to get started with something asap so if you think i would be able to work on bug 373266 i would be very happy to take it.
I'm going to take this off the list since its blocked by a fairly complex bug. I'm also going to go through our widget bugs and find a bunch of other good first bugs. will post back here when I done.
Whiteboard: [good first bug] [lang=c++]
(In reply to Jim Mathies [:jimm] from comment #12)
> I'm going to take this off the list since its blocked by a fairly complex
> bug. I'm also going to go through our widget bugs and find a bunch of other
> good first bugs. will post back here when I done.

https://bugzilla.mozilla.org/buglist.cgi?list_id=11082957&resolution=---&resolution=DUPLICATE&status_whiteboard_type=allwordssubstr&query_format=advanced&status_whiteboard=good%20first%20bug&component=Widget%3A%20Win32&product=Core
Priority: -- → P3
Whiteboard: tpi:+
You need to log in before you can comment on or make changes to this bug.