If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove the side margins in Today Pane

RESOLVED FIXED in 1.5

Status

Calendar
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified

Details

Attachments

(4 attachments)

(Assignee)

Description

6 years ago
Created attachment 596343 [details] [diff] [review]
Remove the margins

All elements in the main view like the ltn-sidebar, the unifinder, the calendar-view and also all elements of TB have no margin with a border around them. Only the Today Pane has this.
(Assignee)

Updated

6 years ago
Attachment #596343 - Attachment is patch: true
Attachment #596343 - Flags: ui-review?(nisses.mail)
Attachment #596343 - Flags: review?(philipp)
(Assignee)

Comment 1

6 years ago
Created attachment 596344 [details]
Before and after patch on Linux
(Assignee)

Comment 2

6 years ago
Created attachment 596345 [details]
Before and after patch on OSX
(Assignee)

Comment 3

6 years ago
Created attachment 596346 [details]
Before and after patch on Win7
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
(Assignee)

Comment 4

6 years ago
The today-pane-splitter for Win7 and Linux has a double border because Philipp asked for this a long time ago.
Comment on attachment 596343 [details] [diff] [review]
Remove the margins

r=philipp

I'm happy to re-evaluate the double-border, I think my concerns were that it would not be obvious that it can be dragged. I'll leave that to Andreas.
Attachment #596343 - Flags: review?(philipp) → review+
Tested on Linux and Mac so far and looks good!
I don't think you need the double border as I think it don't really make it look more draggable, and the mouse cursor should be enough as it is everywhere else, but it looks fine like this too.
Will test on windows as well before I give ui-r+
Comment on attachment 596343 [details] [diff] [review]
Remove the margins

And works great in Windows on all themes too.
Attachment #596343 - Flags: ui-review?(nisses.mail) → ui-review+
(Assignee)

Comment 8

6 years ago
Pushed to comm-central: <http://hg.mozilla.org/comm-central/rev/530066c36f5e>
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.