Closed
Bug 72676
Opened 23 years ago
Closed 23 years ago
crash if right click with mouse inside movie
Categories
(Core Graveyard :: Plug-ins, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9
People
(Reporter: shrir, Assigned: peterlubczynski-bugs)
References
()
Details
(Keywords: crash, regression)
Attachments
(2 files)
294 bytes,
patch
|
Details | Diff | Splinter Review | |
335 bytes,
patch
|
Details | Diff | Splinter Review |
windows trunk 0320 steps: go to the url above right click inside the movie clip observe that the browser just closes..no talkback agent...
Assignee | ||
Comment 1•23 years ago
|
||
Assignee | ||
Comment 2•23 years ago
|
||
This is a regression caused by my recent checkin. On Windows, focus isn't a problem cuz of child windows so we sometimes get those NULL events. That ENSURE macro will take care of that for this problem and future ones. Requesting approvals for checkins.
Severity: normal → critical
Status: NEW → ASSIGNED
Keywords: crash,
regression
Priority: -- → P1
Target Milestone: --- → mozilla0.9
Comment 3•23 years ago
|
||
Peter, are you sure you want an NS_ENSURE here? If it is normal to get the null, then you don't want to bark when it happens do you? Maybe just a null check is all you want...
Assignee | ||
Comment 4•23 years ago
|
||
Assignee | ||
Comment 5•23 years ago
|
||
That sounds resonable. New patch returns NS_ERROR_FAILURE.
Comment 6•23 years ago
|
||
Meow - [s]r=attinasi
Peter, where does this call originate from? In nsObjectFrame it is always being created on stack so the pointer cannot be null physically.
Assignee | ||
Comment 8•23 years ago
|
||
Recall, In order for Shockwave to get keyboard events on Mac, they must first get a focus event. So, I implemented nsIDOMFocusListener. On windows, this is sending through a NULL anEvent.nativemsg in nsPluginHostImpl. On Windows, I guess this event is bogus because child windows get focus anyway. It's not that I'm trapping NULL events because plugins need those, it just so happens that anEvent is NULL in this case.
Assignee | ||
Comment 10•23 years ago
|
||
Patch checked in. new revision: 1.46; previous revision: 1.45
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 11•23 years ago
|
||
yeah , this is no longer crashing. I verified with today's trunk 0327.
Status: RESOLVED → VERIFIED
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•