72689 - nsILoadGroup needs cleanup

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Judson Valeski]

see notes at said url for details.

Comment 1

[Darin Fisher]

fix checked in

Comment 2

[Michael Dunn]

Moving API bug ownership to David Epstein.

Comment 3

[Michael Dunn]

Correction: Changing QA contact for the Embed API bugs to David Epstein.

Comment 4

[David Epstein]

with respect to the API Review notes, here's what's done:
1. In nsIRequest, there's an attribute called loadGroup to access the load group 
(and in nsILoadGroup, there's an nsIRequest attribute to handle a default load 
request)
2. NS_LOADGROUP_CID is now in nsNetCID.h. It's no longer in nsILoadGroup.idl
3. There no longer is nsILoadGroupListenerFactory in the nsILoadGroup.idl file.
4. No longer any references to nsIChannel, nsIStreamListener, and nsIInputStream 
interfaces in nsILoadGroup.idl file.
5. No longer has init() method.
6. Doesn't have groupListenerFactory.
7. nsILoadGroup methods have some documentation.
8. nsILoadGroup.idl is a public interface.
9. activeCount attribute (not function) is in the interface.
10. nsIChannel includes nsIRequest.idl which calls loadGroup.
11. defaultLoadAttributes() no longer in.

Here's what I could not find and have questions about:
1. In the 3/8 notes, it mentions exposing nsIStreamObserver. Don't see any 
mention of this in nsILoadGroup.idl. Jud or Darin, has this been taken care of?

I won't mark this as verified until I find out about this.

Comment 5

[David Epstein]

nsIStreamObserver was renamed nsIRequestObserver. That interface is called in 
nsILoadGroup.idl and there's also an attribute of that type in there (called 
groupObserver)