72720 - Error loading JavaScript functions from parent frame

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[faror]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.4.1 i686; en-US; 0.8.1) Gecko/20010320
BuildID:    2001032008

Worked fine in Build 2001030321
Now clicking on link that uses JavaScript:parent.openNewWindow() generates:
JavaScript error:
 line 0: uncaught exception: [Exception... "Access to property denied"  code:
"1010" nsresult: "0x805303f2 (NS_ERROR_DOM_PROP_ACCESS_DENIED)"  location:
"<unknown>"]



Reproducible: Always
Steps to Reproduce:
1.load http://home.pacbell.net/faror/test.html
2.attempt to click on either link in the frameset



Actual Results:  No new window is opened

Expected Results:  Results received from earlier builds; It opens a new window


Originally encoutered bug using MS Outlook web access which extensivly uses JS
from parent frames. The page referenced above is a simplified example of one of
the functions from MS Outlook web access.

Comment 1

[Phil Schwartau]

Confirming with debug builds 2001-03-19 on WinNT, Linux. OS Linux --> All.

Browser, not engine. Because of the error NS_ERROR_DOM_PROP_ACCESS_DENIED, 
reassigning to Security:General component for analysis - 

I have builds from 2001-03-12 that work fine on this testcase, so that 
narrows the regression a bit -


                                                                                     

Comment 2

[ckritzer (gone)]

I can see some potential for problems if one of the frames loads a page from a 
different domain, but not the same origin.  Mitch, is this the sort of situation 
where document.domain should be being used?

Comment 3

[Mitchell Stoltz (not reading bugmail)]

The problem is that the SchemeIs comparison at nsDocShell.cpp:3286 is returning
false when it should be returning true, because the scheme "JavaScript" is not
being changed internally to lowercase. The workaround is to use
"javascript:parent..." instead of "JavaScript:..." in your links. The solution
is to make sure the scheme name gets lowercased as expected. Reassigning to
Networking.

Comment 4

[Judson Valeski]

Here's the fix.

Index: src/nsSimpleURI.cpp
===================================================================
RCS file: /cvsroot/mozilla/netwerk/base/src/nsSimpleURI.cpp,v
retrieving revision 1.24
diff -u -r1.24 nsSimpleURI.cpp
--- nsSimpleURI.cpp     2001/03/13 02:00:53     1.24
+++ nsSimpleURI.cpp     2001/03/24 00:57:24
@@ -112,6 +112,7 @@
     mScheme = scheme.ToNewCString();
     if (mScheme == nsnull)
         return NS_ERROR_OUT_OF_MEMORY;
+    ToLowerCase(mScheme);
     if (mPath)
         nsCRT::free(mPath);
     mPath = path.ToNewCString();

Comment 5

[Judson Valeski]

fix is in.

Comment 6

[Mitchell Stoltz (not reading bugmail)]

*** Bug 73826 has been marked as a duplicate of this bug. ***