727264 - java.lang.ClassCastException: java.lang.Integer at ProfileMigrator.java:196 if Background Data is turned off

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: logcat

1. go to Android Settings -> Data delivery  -> uncheck Background data
2. install XUL build
3. setup sync
4. install Native build
5. Launch Native

Expected: no crash
Actual: crash

Note: 
1. Droid Pro 2.3, Nightly 02/14/2012

Comment 1

[Richard Newman [:rnewman]]

I don't think this is "Sync is set up" so much as "you have history to migrate".

Comment 2

[Gian-Carlo Pascutto [:gcp]]

This is a regression introduced by modifications in SQLiteBridge. Instead of returning an empty result it returns the number of rows changed, but none of the calling code expects that.

Comment 3

[Gian-Carlo Pascutto [:gcp]]

>I don't think this is "Sync is set up" so much as "you have history to migrate".

Just pointing out for the benefit of QA: it's the exact opposite: "you have places but NO history to migrate" :-)

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 5

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 598894 [details] [diff] [review]
patch

Review of attachment 598894 [details] [diff] [review]:
-----------------------------------------------------------------

The amount of changed rows is only returned if the query returns no results. So on a normal query, this will lose the first (and due to the ordering - most important) history + favicon entry.

Need to fix this to either always return the number of changed rows, make the behavior dependent on whether the query is SELECT/UPDATE/INSERT/DELETE, or return a proper cursor and change all the callers.

Comment 6

[Gian-Carlo Pascutto [:gcp]]

Fixed by bug 726821 (some of the pushes still pointed to this bug)

https://hg.mozilla.org/integration/mozilla-inbound/rev/ff36792efde9
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e6935243310
https://hg.mozilla.org/integration/mozilla-inbound/rev/0bf80d3cebf5
https://hg.mozilla.org/integration/mozilla-inbound/rev/bebeca2270ee

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/ff36792efde9
https://hg.mozilla.org/mozilla-central/rev/3e6935243310
https://hg.mozilla.org/mozilla-central/rev/0bf80d3cebf5
https://hg.mozilla.org/mozilla-central/rev/bebeca2270ee

Comment 8

[Cristian Nicolae (:xti)]

Verified fixed on:

Firefox 13.0a1 (2012-02-29)
20120229031108
http://hg.mozilla.org/mozilla-central/rev/30b4f99a137c

--
Device: Motorola Droid PRO
OS: Android 2.3.3