727381 - Haptic feedback clobbers vibrations started via the vibrator API

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Paul Rouget [:paul]]

I use this test case:

<button onclick="navigator.mozVibrate(2000)">Doesn't work</button>
<button onclick="navigator.mozVibrate(2000); alert(42)">Work</button>

Fennec nightly (2012-02-15), HTC Desire HD + ICS.

Comment 1

[Paul Rouget [:paul]]

(works with Galaxy Nexus + ICS)

Comment 2

[Justin Lebar (not reading bugmail)]

What the heck is going on here?

Comment 3

[Justin Lebar (not reading bugmail)]

On my ICS device, vibrate(2000) causes a very brief vibration.

Comment 4

[Justin Lebar (not reading bugmail)]

I think this is an ICS-only problem; the vibrator works fine on my SGSII running 2.3.

Comment 5

[Justin Lebar (not reading bugmail)]

There's no cancelVibrate() call being sent, so I wonder why our vibration is being cancelled.

Comment 6

[Justin Lebar (not reading bugmail)]

(In reply to Paul Rouget [:paul] from comment #1)
> (works with Galaxy Nexus + ICS)

Do you mean, it works as expected, or that you're able to reproduce the problem?

Can we talk specific versions of Android?  I can reproduce on my Nexus S running 4.0.3, kernel 3.0.8-gb55e9ac android-build@apa28 #1.

Comment 7

[Justin Lebar (not reading bugmail)]

Aha.  I think it's the haptic feedback.  When you click a button, someone is doing a small vibration to let you know that you've clicked it.  That's overwriting the vibration.

Comment 8

[Justin Lebar (not reading bugmail)]

Jonas, remember when we worried about pages nuking each others' navigator.vibrate() calls?  I never suspected Firefox would be the first offender!

Comment 9

[Justin Lebar (not reading bugmail)]

Attachment: Patch v1

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 597550 [details] [diff] [review]
Patch v1

Passing to Brad. Looks OK to me but he is better for reviewing this.

Comment 11

[Justin Lebar (not reading bugmail)]

Thanks for the quick review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/41c96fa5d43f

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/41c96fa5d43f

Comment 13

[Paul Rouget [:paul]]

(thank you)