727438 - Grey horizontal band of pixels on bottom layer of URL bar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Cristian Nicolae (:xti)]

Attachment: screenshot

The grey horizontal band is visible both in landscape and portrait on Samsung Galaxy TAB 10.1

--
Firefox 13.0a1 (2012-02-15)
20120215040239
http://hg.mozilla.org/projects/maple/rev/c8e21328ea71

Comment 1

[Aaron Train [:aaronmt]]

This has nothing to do with GL Layers, and happens on Nightly.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Aah, I remember this. Honeycomb uses a 56dip ActionBar. However our image for "mdpi" is just 48dip and hence it starts repeating. I would like to wait till tablet UI is finalized to come up with a solution for this.

Comment 3

[Aaron Train [:aaronmt]]

Seeing this on the Galaxy Nexus frequently.

Comment 4

[Aaron Train [:aaronmt]]

Attachment: Nightly (03/13) - Galaxy Nexus (Android 4.0.2)

Comment 5

[Sriram Ramasubramanian [:sriram]]

I tried tracking the rotation changes at Application level and passing it to GeckoApp. There is a race condition here:

When the application is in background:
- Application gets the rotation change

When the application is in foreground:
- Either of application or activity can get the rotation change first.

And if the application receives it and informs GeckoApp, and GeckoApp tries to redraw the layout (but still feels the orientation is not changed), we run into this grey band of pixels in the URL bar -- basically the resources are taken for the other orientation.

Posting the redrawing after a time delay doesn't help either. There is an animation happening during the rotation, and the time taken for it is not constant.

A better approach would be fire 3 re-draws per rotation, at say 500ms interval.

Comment 6

[Sriram Ramasubramanian [:sriram]]

3 re-draws per rotation works fine on Nexus S. There is no flickering too. However, Galaxy Nexus is reluctant to draw. I still see this issue with the grey bar showing up.

I've tried invalidating drawables, still it doesn't work. Some weak-reference

Comment 7

[Sriram Ramasubramanian [:sriram]]

.. (accidental enter in previous comment :( ) continuing.. 

Some weak-reference in Resources is the trouble.

Comment 8

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

As per discussions with @mfinkle, this patch uses same resources for both portrait and landscape. This fixes the grey horizontal bar. However, the urlbar is compressed by 4dp's.

The action bar is _not_ re-inflated on rotation -- this avoids flickering of url bar on rotation.

Comment 9

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This is same as old patch, with the font-size restricted to 22 for both landscape and portrait.

Comment 10

[Sriram Ramasubramanian [:sriram]]

Attachment: Screenshot: Nexus S - Portrait

Comment 11

[Sriram Ramasubramanian [:sriram]]

Attachment: Screenshot: Nexus S - Landscape

Comment 12

[Sriram Ramasubramanian [:sriram]]

Attachment: Screenshot: Galaxy Nexus - Portrait

Comment 13

[Sriram Ramasubramanian [:sriram]]

Attachment: Screenshot: Galaxy Nexus - Landscape

Comment 14

[Sriram Ramasubramanian [:sriram]]

Working on this for weeks and weeks, something finally catches my attention! :O
Everything is re-inflated properly, except for the background. Probably something is getting cached wrongly.

As a band-aid, I ll post a patch that uses abouthome's background to be the background of urlbar. Thereby, no gradients, hence no grey bar.

Comment 15

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch: Changing the gradiented background to non-gradiented version

This changes the gradiented background to non-gradiented version -- like in about:home.

Comment 16

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch: Option 2 and a half

I was thinking of creating a new drawable folder "drawable-land/" (i know! :( ), and copying the address_bag_bg.xml into it.
And it works!!! Android properly finds the resources for portrait and landscape for "repeating" and does the job perfectly! :( :( :( 

There is one small bar at the bottom, which I should investigate -- if it has to do with ActionBar height or something else.

Comment 17

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 607770 [details] [diff] [review]
Patch: Option 2 and a half

I assume this is the patch you think best fixes the bug. Looks OK to me.

Comment 18

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 607761 [details] [diff] [review]
Patch: Changing the gradiented background to non-gradiented version

I don't think this is your favorite patch, so I am obsoleting it.

Comment 19

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch: Final

This is the final patch! phew!! :O :O :O

The previous patch used drawable-land/ -- which will affect landscape on pre-ICS phones. This patch uses drawable-land-v14/ -- which is the correct one.
Also, I have resorted to renaming the address_bar_texture to "port" and "land" versions so that android doesn't get confused :D

After these changes, I found a small little line on landscape mode. On a close investigation at 500% zoomed in state, myself and Ian found that there was a transparent line at the bottom of the resources. Ian gave newer resources to solve that problem.

With this patch, we can be sure that we have have grey-bar problem.

Note: this patch doesn't fix tablets. They will be fixed based on the tablet UI and action-bar specifications once we start working on tablets. This only fixes Galaxy Nexus and Nexus S running ICS.

Comment 20

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/9044401e00d8

Comment 21

[Aaron Train [:aaronmt]]

\o/

Comment 22

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/9044401e00d8

Comment 23

[Paul Feher]

Verified/fixed on:
Nightly Fennec 14.0a1 (2012-03-29)
Device: Galaxy Nexus - Android 4.0.2
Device: Samsung Nexus S - Android 2.3.6