Closed Bug 727474 Opened 14 years ago Closed 14 years ago

Failure in testSearchSuggestions | Auto-complete popup has been closed

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: remus.pop, Unassigned)

References

()

Details

(Whiteboard: [mozmill-test-failure][mozmill-test-skipped])

Attachments

(1 file, 2 obsolete files)

TEST: /testSearch/testSearchSuggestions.js | testMultipleEngines() ERROR: Auto-complete popup has been closed WHEN: 15.02.2012 FIRST: 2012-02-07 BRANCHES: 1.9.2 This only occurs on Windows and Mac. On Linux this test is skipped. This has been failing since we landed bug 714802 on 1.9.2 branch.
Please submit a patch to disable this test. If it's skipped on one platform it should be skipped for all.
Attached patch skip test (1.9.2) (obsolete) — Splinter Review
Skips the test.
Attachment #599164 - Flags: review?(alex.lakatos)
Comment on attachment 599164 [details] [diff] [review] skip test (1.9.2) ># HG changeset patch ># User Remus Pop <remus.pop@softvision.ro> ># Date 1329837791 -7200 ># Branch mozilla-1.9.2 ># Node ID cc62f663997fefdbf4e6c2e60433082353f87586 ># Parent a92e1f34a451e82058702b87ef350047890dda75 >Bug 727474 - Failure in testSearchSuggestions | Auto-complete popup has been closed r=alex.lakatos Reword the commit message to "Bug 727474 disable testSearch/testSearchSuggestions.js due to failure. r=alex.lakatos" >+// Bug 727474 - Failure in testSearchSuggestions | Auto-complete popup has been >+// closed >+setupModule.__force_skip__ = "Bug 727474 - Failure in testSearchSuggestions |"+ >+ "Auto-complete popup has been closed" > > // Bug 609077: Search suggestions are not always displayed > if (mozmill.isLinux) { > setupModule.__force_skip__ = "Bug 609077: Search suggestions are not always displayed"; > } Disable the linux skip if you are adding a skip for all platforms, with a reminder XXX comment to re-enable it after fixing the test.
Attachment #599164 - Flags: review?(alex.lakatos) → review-
Attached patch skip test v2 (1.9.2) (obsolete) — Splinter Review
All requests were addressed.
Attachment #599164 - Attachment is obsolete: true
Attachment #599171 - Flags: review?(alex.lakatos)
Attachment #599171 - Flags: review?(anthony.s.hughes)
Attachment #599171 - Flags: review?(alex.lakatos)
Attachment #599171 - Flags: review+
Comment on attachment 599171 [details] [diff] [review] skip test v2 (1.9.2) If we are disabling this across all platforms, simply remove the IF block altogether.
Attachment #599171 - Flags: review?(anthony.s.hughes) → review-
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #5) > Comment on attachment 599171 [details] [diff] [review] > skip test v2 (1.9.2) > > If we are disabling this across all platforms, simply remove the IF block > altogether. I think it's better to stay there because it's easier to uncomment when you see it, rather than looking in the patch attached to the bug. Let me know if we still want it removed or if you have a different opinion.
That's a valid point. However, I wonder if leaving the IF block in place (uncommented) will cause problems (ie. double skip). Can you test this out?
I get the same results when running the test with the "if" left out or in.
Okay, so let's leave the section in but uncommented.
As requested, the skip for linux has been left untouched.
Attachment #599171 - Attachment is obsolete: true
Attachment #601202 - Flags: review?(anthony.s.hughes)
Attachment #601202 - Flags: review?(anthony.s.hughes) → review+
Comment on attachment 601202 [details] [diff] [review] disable v3 (1.9.2) [landed] Landed: http://hg.mozilla.org/qa/mozmill-tests/rev/b714c4174301 (mozilla-1.9.2)
Attachment #601202 - Attachment description: patch v3 (1.9.2) → disable v3 (1.9.2) [landed]
Test has been disabled. Since this is only happening on 1.9.2, resolving WONTFIX.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
Whiteboard: [mozmill-test-failure] → [mozmill-test-failure][mozmill-test-skipped]
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: